Skip to content

Commit 3dec2f5

Browse files
authored
Merge pull request #119 from Fishbowler/118_fixRoomList
fixes 118: Return full room list from /chatrooms when not searching
2 parents 6ef4ba7 + 1813f10 commit 3dec2f5

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

changelog.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ <h1>
4646

4747
<p><b>1.8.3</b> ???</p>
4848
<ul>
49+
<li>[<a href='https://github.com/igniterealtime/openfire-restAPI-plugin/issues/118'>#118</a>] - Cannot retrieve full list of rooms following #113</li>
4950
<li>[<a href='https://github.com/igniterealtime/openfire-restAPI-plugin/issues/113'>#113</a>] - MUC search including naturalName</li>
5051
</ul>
5152

src/java/org/jivesoftware/openfire/plugin/rest/controller/MUCRoomController.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,12 +175,10 @@ public MUCRoomEntities getChatRooms(String serviceName, String channelType, Stri
175175
List<MUCRoomEntity> mucRoomEntities = new ArrayList<>();
176176

177177
for (MUCRoomSearchInfo roomInfo : roomsInfo) {
178-
String roomName = "";
178+
String roomName = roomInfo.getName();
179179
if (roomSearch != null) {
180-
if (StringUtils.containsIgnoringCase(roomInfo.getName(), roomSearch) ||
181-
StringUtils.containsIgnoringCase(roomInfo.getNaturalLanguageName(), roomSearch)) {
182-
roomName = roomInfo.getName();
183-
} else {
180+
if (!StringUtils.containsIgnoringCase(roomInfo.getName(), roomSearch) &&
181+
!StringUtils.containsIgnoringCase(roomInfo.getNaturalLanguageName(), roomSearch)) {
184182
continue;
185183
}
186184
}

0 commit comments

Comments
 (0)