-
Notifications
You must be signed in to change notification settings - Fork 0
feat(spring-wolf-example): update Kafka bindings and improve Dockerfi… #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| wrapperVersion=3.3.4 | ||
| distributionType=only-script | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.12/apache-maven-3.9.12-bin.zip | ||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/4.0.0-rc-4/apache-maven-4.0.0-rc-4-bin.zip | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,7 +16,7 @@ COPY ./src src/ | |||||
| RUN --mount=type=bind,source=pom.xml,target=pom.xml \ | ||||||
| --mount=type=cache,target=/root/.m2 \ | ||||||
| ./mvnw package -DskipTests && \ | ||||||
| mv target/$(./mvnw help:evaluate -Dexpression=project.artifactId -q -DforceStdout)-$(./mvnw help:evaluate -Dexpression=project.version -q -DforceStdout).jar target/app.jar | ||||||
| mv target/*.jar target/app.jar | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wildcard If the build produces more than one Consider being more specific, e.g., using the artifact name or ensuring only one JAR exists: Proposed fix- mv target/*.jar target/app.jar
+ mv target/springwolf-example-*.jar target/app.jar📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| FROM package as extract | ||||||
|
|
||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| <parent> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.5.10</version> | ||
| <version>4.0.2</version> | ||
| <relativePath/> | ||
| </parent> | ||
|
|
||
|
|
@@ -19,8 +19,8 @@ | |
|
|
||
| <properties> | ||
| <java.version>21</java.version> | ||
| <spring.boot.version>3.5.10</spring.boot.version> | ||
| <maven.plugin.version>3.15.0</maven.plugin.version> | ||
| <spring.boot.version>4.0.2</spring.boot.version> | ||
| <maven.plugin.version>4.0.0-beta-4</maven.plugin.version> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🌐 Web query:
💡 Result:
Notes: it’s still a “beta” (pre-final 4.0.0) line, and the Maven 3 compatible line continues separately (e.g., Sources: [1] (repo.maven.apache.org) [2] (maven.apache.org) [3] (maven.apache.org) [4] (mail-archive.com) [5] (mail-archive.com) Citations:
🌐 Web query:
💡 Result: As of February 17, 2026, Apache Maven 4 is not yet GA (generally available). The latest pre-release listed by the Maven project is Maven 4.0.0-rc-5, released November 13, 2025 (requires Java 17). [1][2] For context, the latest Maven 3 GA release shown is 3.9.12 (released December 13, 2025). [1] Sources 🌐 Web query:
💡 Result: As of February 2026, the latest stable release of There is also a newer pre-release for Maven 4: Maven config (stable): <plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.15.0</version>
</plugin>Sources: [1] [2] [3]
Maven Compiler Plugin 4.0.0-beta-4 (released January 27, 2026) is a beta version designed for the upcoming Maven 4, which remains under development. As of February 2026, Maven 4 has not reached GA status (latest is 4.0.0-rc-5 from November 2025). Using beta tooling introduces build instability risks. For production use, prefer the latest stable version 3.15.0 (released February 1, 2026), which is fully compatible with Maven 3.9.12. 🤖 Prompt for AI Agents |
||
| <spring.cloud.kafka>5.0.1</spring.cloud.kafka> | ||
| <lombok.version>1.18.42</lombok.version> | ||
| <springwolf.version>2.0.0</springwolf.version> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -36,7 +36,7 @@ public class KafkaProducer { | |||||
| @KafkaAsyncOperationBinding(bindingVersion = "1.0.0") | ||||||
| public void send(String text) { | ||||||
| KafkaDto message = new KafkaDto(text); | ||||||
| bridge.send("sendMessage-out-0", message); | ||||||
| bridge.send("kafkaV2Producer-out-0", message); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Binding name mismatch — producer will not route to the configured topic. The Either the code or the YAML must be updated to match: Option A: Fix the code to match the YAML- bridge.send("kafkaV2Producer-out-0", message);
+ bridge.send("kafkaProducer-out-0", message);Option B: Fix the YAML to match the codeIn - kafkaProducer-out-0:
+ kafkaV2Producer-out-0:📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| } | ||||||
|
|
||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maven 4.0.0-rc-4 is not the latest release candidate; rc-5 is available.
Maven 4.0.0-rc-4 aims at being the last release candidate before Maven 4.0.0 GA. However, a new release candidate, 4.0.0-rc-5, was released on Nov 13. Note that a bug has been found in the bean configuration system where field accessibility state is cached globally. This can cause plugin configuration injection to fail when the same configuration field is accessed multiple times or in different contexts during a build. Consider updating to rc-5 or waiting for GA.
🤖 Prompt for AI Agents