A11Y improvements#373
Conversation
|
@igordanchenko It's up! I've moved back the focus to the container and removed the |
|
@ubermanu I've pushed my commits. Please take a look. Notable changes:
|
|
@igordanchenko LGTM! You don't have issues anymore with |
I no longer see the same issue as I did before. I guess the changes to roles and the DOM structure we have implemented made a difference. Previously, VoiceOver wouldn't announce slide titles and descriptions at all. In the current implementation, it still doesn't announce the title and description of the very first slide, but it starts announcing them as you continue to rotate through the slides. Also, in Safari, it appears to announce thumbnail buttons. It only happens when I open the lightbox and start changing slides using the keyboard arrow keys. I'm not sure if that's expected. |
|
On MacOS 14 Sonoma, VoiceOver restitutes everything correctly, using TAB in interactive mode, and Up/Down arrows in reading mode. Idem with NVDA and Narrator on Windows 11. |
this caused the content of the modal to be announced twice because the inner carousel already has aria-live=polite
Add aria-label to describe the content of the carousel
Let AT announce the dialog role, followed by a label that describes its content
Focus should be contained into the modal until ESC is pressed
main wrapper is already set up to inert
The controls are announced by AT if contained in the aria-live=polite gallery
…side the carousel
|
🎉 This PR is included in version 3.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Follow up of #362
Checklist