feat: dim readOnly variables

Author: igorlfs

lua/dap-view/globals.lua

@@ -4,4 +4,5 @@ return {
     NAMESPACE = vim.api.nvim_create_namespace("dap-view"),
     NAMESPACE_VT = vim.api.nvim_create_namespace("dap-view-vt"),
     HL_PREFIX = "NvimDapView",
+    HAS_0_12 = vim.fn.has("nvim-0.12") == 1,
 }

lua/dap-view/highlight.lua

@@ -2,8 +2,6 @@ local globals = require("dap-view.globals")
 
 local api = vim.api
 
-local has_0_12 = vim.fn.has("nvim-0.12") == 1
-
 ---@param name string
 ---@param link string?
 ---@param opts vim.api.keyset.highlight?
@@ -54,7 +52,7 @@ local define_base_links = function()
     hl_create("Function", "Function")
     hl_create("Constant", "Constant")
 
-    if not has_0_12 then
+    if not globals.HAS_0_12 then
         return
     end
 

lua/dap-view/hover/view.lua

@@ -79,7 +79,7 @@ local function show_variables(variables_reference, parent_path, line, depth, can
         state.hover_path_to_evaluate_name[path] = variable.evaluateName
         state.hover_path_to_parent_reference[path] = variables_reference
 
-        local type_hl_group = variable.type and hl.types_to_hl_group[variable.type:lower()]
+        local type_hl_group = hl.hl_from_variable(variable)
 
         local hl_start = depth + #prefix
         canvas.highlights[#canvas.highlights + 1] = {
@@ -135,7 +135,7 @@ M.show = function(bufnr)
 
             canvas.contents[#canvas.contents + 1] = trimmed_content
 
-            local type_hl_group = hover.response.type and hl.types_to_hl_group[hover.response.type:lower()]
+            local type_hl_group = hl.hl_from_variable(hover.response)
 
             local hl_start = #prefix
             canvas.highlights[#canvas.highlights + 1] = {
@@ -157,7 +157,7 @@ M.show = function(bufnr)
 
             width = #result
 
-            local type_hl_group = hover.response.type and hl.types_to_hl_group[hover.response.type:lower()]
+            local type_hl_group = hl.hl_from_variable(hover.response)
 
             canvas.highlights[#canvas.highlights + 1] = {
                 type_hl_group and { type_hl_group, { height, 0 }, { height, -1 } } or nil,

lua/dap-view/scopes/view.lua

@@ -86,8 +86,7 @@ local function show_variables(variables_reference, parent_path, line, depth, can
         state.variable_path_to_evaluate_name[path] = variable.evaluateName
         state.variable_path_to_parent_reference[path] = variables_reference
 
-        local type_hl_group = (updated and "WatchUpdated")
-            or (variable.type and hl.types_to_hl_group[variable.type:lower()])
+        local type_hl_group = (updated and "WatchUpdated") or hl.hl_from_variable(variable)
 
         local hl_start = depth + #prefix
         canvas.highlights[#canvas.highlights + 1] = {

lua/dap-view/util/hl.lua

@@ -42,4 +42,19 @@ M.types_to_hl_group = {
     asyncfunction = "Function",
 }
 
+---@param v dap.Variable|dap.EvaluateResponse
+M.hl_from_variable = function(v)
+    local hl = v.type and M.types_to_hl_group[v.type:lower()]
+
+    if
+        globals.HAS_0_12
+        and v.presentationHint
+        and vim.tbl_contains(v.presentationHint.attributes or {}, "readOnly")
+    then
+        hl = hl .. "Dim"
+    end
+
+    return hl
+end
+
 return M

lua/dap-view/util/statusline.lua

@@ -2,14 +2,12 @@ local global = require("dap-view.globals")
 
 local M = {}
 
-local nightly = vim.fn.has("nvim-0.12") == 1
-
 ---@param text string
 ---@param group string
 ---@param inherit boolean?
 ---@param clean boolean?
 M.hl = function(text, group, inherit, clean)
-    local field = (inherit and nightly) and "$" or "#"
+    local field = (inherit and global.HAS_0_12) and "$" or "#"
     local part = "%" .. field .. global.HL_PREFIX .. group .. field .. text
     if clean or clean == nil then
         return part .. "%*"

lua/dap-view/watches/view.lua

@@ -38,8 +38,7 @@ local function show_variables(children, reference, line, depth)
         local hl_start = depth + #prefix
         hl.hl_range("WatchExpr", { line, hl_start }, { line, hl_start + #variable.name })
 
-        local hl_group = (child.updated and "WatchUpdated")
-            or (variable.type and hl.types_to_hl_group[variable.type:lower()])
+        local hl_group = (child.updated and "WatchUpdated") or hl.hl_from_variable(variable)
 
         if hl_group then
             hl.hl_range(hl_group, { line, hl_start + #variable.name + 3 }, { line, -1 })
@@ -131,7 +130,7 @@ M.show = function()
 
             local hl_group = err and "WatchError"
                 or view.updated and "WatchUpdated"
-                or response and response.type and hl.types_to_hl_group[response.type:lower()]
+                or response and hl.hl_from_variable(response)
 
             if hl_group then
                 local hl_start = #prefix + #expression + 3