do not use open_client to get version

Author: igorvoltaic

pyiceberg/catalog/hive.py

@@ -407,12 +407,12 @@ def _create_hive_table(self, open_client: Client, hive_table: HiveTable) -> None
             raise TableAlreadyExistsError(f"Table {hive_table.dbName}.{hive_table.tableName} already exists") from e
 
     def _get_hive_table(self, open_client: Client, *, dbname: str, tbl_name: str) -> HiveTable:
-        if open_client._hive_version < 4:
+        if self._client._hive_version < 4:
             return open_client.get_table(dbname=dbname, tbl_name=tbl_name)
         return open_client.get_table_req(GetTableRequest(dbName=dbname, tblName=tbl_name)).table
 
     def _get_table_objects_by_name(self, open_client: Client, *, dbname: str, tbl_names: list[str]) -> list[HiveTable]:
-        if open_client._hive_version < 4:
+        if self._client._hive_version < 4:
             return open_client.get_table_objects_by_name(dbname=dbname, tbl_names=tbl_names)
         return open_client.get_table_objects_by_name_req(GetTablesRequest(dbName=dbname, tblNames=tbl_names)).tables
 

tests/catalog/test_hive.py

@@ -955,7 +955,7 @@ def test_rename_table_from_does_not_exists() -> None:
     catalog = HiveCatalog(HIVE_CATALOG_NAME, uri=HIVE_METASTORE_FAKE_URL)
 
     catalog._client = MagicMock()
-    catalog._client.__enter__()._hive_version = 3
+    catalog._client._hive_version = 3
     catalog._client.__enter__().alter_table_with_environment_context.side_effect = NoSuchObjectException(
         message="hive.default.does_not_exists table not found"
     )
@@ -970,7 +970,7 @@ def test_rename_table_to_namespace_does_not_exists() -> None:
     catalog = HiveCatalog(HIVE_CATALOG_NAME, uri=HIVE_METASTORE_FAKE_URL)
 
     catalog._client = MagicMock()
-    catalog._client.__enter__()._hive_version = 3
+    catalog._client._hive_version = 3
     catalog._client.__enter__().alter_table_with_environment_context.side_effect = InvalidOperationException(
         message="Unable to change partition or table. Database default does not exist Check metastore logs for detailed stack.does_not_exists"
     )