gf180: fix access rights for klayout macro#275
Open
Scafir wants to merge 1 commit into
Open
Conversation
Member
|
@Scafir Before merging this, we should discuss an alternative way. PDK locations should always be read-only, so if there is a file to be modified, it should be in user space. How difficult would it be to achieve this? |
Author
|
I agree. This is not something I had in mind when I made my improvements in the PDK. For the DRC/LVS options, I am not sure how to implement a solution that is cross-plateform compatible. I will think about this, but it cannot be too hard. I will also need to make sure write access is not required elsewhere (e.g: xschem LVS netlist to klayout conversion). |
Member
|
@Scafir Exactly. What can be safely used is
|
This fixes a regression introduced by 56ee4b0 Fixes iic-jku#273
1200f30 to
a63219a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced by 56ee4b0, which removed access rights to the pdk.
It is currently required for:
Fixes #273