Skip to content

Add Sutherland's law transport model#1070

Draft
tulioricci wants to merge 20 commits into
mainfrom
tulio/transport
Draft

Add Sutherland's law transport model#1070
tulioricci wants to merge 20 commits into
mainfrom
tulio/transport

Conversation

@tulioricci
Copy link
Copy Markdown
Collaborator

Add transport model for comparison with openFoam.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant