Skip to content

Add tpe testing in diffusion#1085

Draft
MTCam wants to merge 14 commits into
mainfrom
add-more-tpe-testing
Draft

Add tpe testing in diffusion#1085
MTCam wants to merge 14 commits into
mainfrom
add-more-tpe-testing

Conversation

@MTCam
Copy link
Copy Markdown
Member

@MTCam MTCam commented Nov 12, 2024

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

Copy link
Copy Markdown
Contributor

@anderson2981 anderson2981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants