Add option to compile the full timestepper in advance_state#1087
Open
majosm wants to merge 1 commit into
Open
Conversation
7d5015a to
93f01e5
Compare
93f01e5 to
136b376
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to compile the whole timestepper in
advance_stateinstead of just the RHS. Lowers the performance floor somewhat for prediction on lassen when using Euler timestepping (0.04s -> 0.014s).Might be useful @MTCam @anderson2981. It's not without its pitfalls though: only use it with Euler integration (integrators with multiple RHS calls will construct a mega-DAG with multiple RHSes), and it's probably not going to play well with filtering as it's currently implemented in the prediction driver. Turn off the RHS compile in the driver before using this.
Questions for the review: