Update cantera to version 3.0.0#989
Conversation
91468e7 to
4b52f64
Compare
| pyro_p = pyro_mechanism.get_pressure(pyro_m, pyro_t, yin) | ||
| pyro_h = pyro_mechanism.get_mixture_enthalpy_mass(pyro_t, yin) | ||
| pyro_s = pyro_mechanism.get_mixture_entropy_mass(pyro_p, pyro_t, yin) | ||
| # pyro_s = pyro_mechanism.get_mixture_entropy_mass(pyro_p, pyro_t, yin) |
There was a problem hiding this comment.
Per Pyrometheus review, we won't add entropy to its native functions. I am wondering if I should remove it completely or add local functions somewhere to keep the verification.
There was a problem hiding this comment.
If it is no longer in the base package and the corresponding test was removed there, then this is the right thing to do. I was just curious about the removal. (I'd lean on complete removal).
| if use_overintegration: | ||
| quadrature_tag = DISCR_TAG_QUAD | ||
| else: | ||
| quadrature_tag = None |
There was a problem hiding this comment.
Removed because it is useless without spatial operators.
MTCam
left a comment
There was a problem hiding this comment.
I am not sure I am comfortable removing the fluid stuff for this example. It is not wasted on me that it is largely non-participant in this example, but part of the example was showing how to have chem+fluid in the simulation.
My plan is to make However, I can keep the spatial terms in |
I'm not opposed. Hearing your plan makes it seem like a good idea. |
Depends on Updates for Compatibility with the new Cantera 3.0 Release pyrometheus/pyrometheus#75autoignition.pyand further modify it to easy the comparison against pyrometheus and canteramechanismlocationQuestions for the review: