feat: adding default set of counters for retry wrappers#145
Merged
Conversation
…ryKey can now fill-in counters with arbitrary ids
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #145 +/- ##
============================================
- Coverage 82.31% 82.29% -0.03%
- Complexity 789 792 +3
============================================
Files 147 147
Lines 2098 2118 +20
Branches 120 120
============================================
+ Hits 1727 1743 +16
- Misses 291 295 +4
Partials 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
theo-malka
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additions:
RetryStepandRetrySink)Additional metrics for steps are the following:
pipeline.step.retry.run_count(count) : how many times the wrapper was executedpipeline.step.retry.run_success(count) : how many times the wrapper succeededpipeline.step.retry.run_failure(count) : how many times the wrapper failed (retry exhausted)pipeline.step.retry.retry_count(count) : how many times a retry was attemptedpipeline.step.retry.retry_success(count) : how many times a retry attempt succeededpipeline.step.retry.retry_failure(count) : how many times a retry attempt failedAdditional metrics for sinks are the following:
pipeline.sink.retry.run_count(count) : how many times the wrapper was executedpipeline.sink.retry.run_success(count) : how many times the wrapper succeededpipeline.sink.retry.run_failure(count) : how many times the wrapper failed (retry exhausted)pipeline.sink.retry.retry_count(count) : how many times a retry was attemptedpipeline.sink.retry.retry_success(count) : how many times a retry attempt succeededpipeline.sink.retry.retry_failure(count) : how many times a retry attempt failed