fix: use a container for retry count#146
Merged
theo-malka merged 1 commit intomasterfrom Apr 15, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
============================================
- Coverage 80.14% 80.12% -0.02%
- Complexity 819 821 +2
============================================
Files 156 156
Lines 2342 2350 +8
Branches 126 126
============================================
+ Hits 1877 1883 +6
- Misses 385 387 +2
Partials 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clement-ndt
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retry.getMetrics().getNumberOfTotalCalls()methods provide the totalNumber of retries since the application startup while we want to get the retry count for the currentcontext.pipelineTag().uid().Not sure if using a Map to keep the entries could cause performance issues but it should be OK as we remove entries at the end of the execution.