Skip to content

Commit cceb19a

Browse files
committed
chore: 해결된 TODO 제거
1 parent 3c05116 commit cceb19a

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

WebtoonScraper/scrapers/_lezhin_comics.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ async def get_episode_image_urls(self, episode_no: int, retry: int = 3) -> list[
283283
is_purchased = self.purchased_episodes[episode_no] if hasattr(self, "purchased_episodes") else False
284284

285285
purchased = "true" if is_purchased else "false"
286-
# 스페셜 캐릭터를 포함하고 있는 이상한 웹툰이 있음. # TODO: 테스트에 포함하기!
286+
# 스페셜 캐릭터를 포함하고 있는 이상한 웹툰이 있음
287287
episode_id_str = urllib.parse.quote(self.episode_ids[episode_no])
288288
episode_id_int = self.episode_int_ids[episode_no]
289289

@@ -398,16 +398,16 @@ async def _download_image(
398398
/,
399399
directory: Path,
400400
name: str,
401-
episode_no: int | None = None, # TODO: 이 episode_no를 바탕으로 다른 정보들을 가져오기
401+
episode_no: int | None = None,
402402
) -> Path:
403403
if isinstance(url_tuple, str):
404404
return await super()._download_image(url_tuple, directory, name)
405405

406406
episode_no, url, media_type = url_tuple
407407
if media_type not in ("image/jpeg", "image/gif", "image/png"):
408408
logger.warning(f"Unknown media type: {media_type}")
409-
if media_type.startswith("image"):
410-
file_extension = media_type.removeprefix("image/") # TODO: 이거 없이도 잘 작동하는지 확인하고 아니라면 변경하기
409+
if media_type.startswith("image/"):
410+
file_extension = media_type.removeprefix("image/")
411411

412412
if not self.is_shuffled or not self.unshuffle_immediately:
413413
return await super()._download_image(url, directory, name)

WebtoonScraper/scrapers/_naver_webtoon.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ async def fetch_episode_information(self, *, reload: bool = False) -> None:
8282
await self.fetch_webtoon_information()
8383
raise
8484

85-
# TODO: 혹이 HTTP 304를 이용하지는 않을까? 한번 코드를 돌려 보며 확인해야 한다.
8685
current_articles = data["articleList"]
8786
if previous_articles == current_articles:
8887
break

0 commit comments

Comments
 (0)