Do not emit restriction warning on inherited method (eclipse-jdt#4293)

Currently when we have a type A and it is accessible from package p1, but extends a type B (that is not accessible in package p2) calling any public method B.m() via A triggers a restriction warning.

In the context of OSGi, where a caller has access to all public methods of A including inherited ones, this is undesired.

See eclipse-jdt#4293 for a discussion about that topic.

Author: laeubi

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/ast/MessageSend.java

@@ -1002,7 +1002,10 @@ public TypeBinding resolveType(BlockScope scope) {
 		}
 		// abstract private methods cannot occur nor abstract static............
 	}
-	if (isMethodUseDeprecated(this.binding, scope, true, this))
+	TypeBinding declared = this.binding.declaringClass.erasure();
+	TypeBinding actual = this.actualReceiverType.erasure();
+	boolean isExplicitUse = TypeBinding.equalsEquals( declared, actual);
+	if (isMethodUseDeprecated(this.binding, scope, isExplicitUse, this))
 		scope.problemReporter().deprecatedMethod(this.binding, this);
 
 	TypeBinding returnType;