Constant referenced in annotation is not recognized as a constant value (eclipse-jdt#4840)

* Fixes eclipse-jdt#4835

Author: srikanth-sankaran

org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java

@@ -1391,7 +1391,7 @@ public FieldBinding getField(char[] fieldName, boolean needResolve) {
 	if ((this.tagBits & TagBits.AreFieldsComplete) != 0)
 		return ReferenceBinding.binarySearch(fieldName, this.fields);
 
-	if ((this.tagBits & TagBits.HasUnresolvedComponents) != 0)
+	if (needResolve && (this.tagBits & TagBits.HasUnresolvedComponents) != 0)
 		components();
 
 	// lazily sort fields

org.eclipse.jdt.core.tests.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/RecordsRestrictedClassTest.java

@@ -11806,4 +11806,59 @@ record DoublePoint(Point p1, Point p2) {
 				"Cannot make a static reference to the non-static variable args\n" +
 				"----------\n");
 }
+// https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4835
+// Constant referenced in annotation is not recognized as a constant value
+public void testIssue4835() throws Exception {
+	this.runConformTest(
+		new String[] {
+					"testing/X.java",
+					"""
+					package testing;
+
+					import testing.X.JsonProperties;
+
+					import java.lang.annotation.ElementType;
+					import java.lang.annotation.Retention;
+					import java.lang.annotation.RetentionPolicy;
+					import java.lang.annotation.Target;
+
+					@Target({ElementType.ANNOTATION_TYPE, ElementType.FIELD, ElementType.METHOD, ElementType.PARAMETER})
+					@Retention(RetentionPolicy.RUNTIME)
+
+					@interface JsonProperty {
+						String value();
+					}
+
+					@Target({ElementType.ANNOTATION_TYPE, ElementType.TYPE,
+					    ElementType.METHOD, ElementType.CONSTRUCTOR, ElementType.FIELD})
+					@Retention(RetentionPolicy.RUNTIME)
+
+					@interface JsonPropertyOrder {
+					    public String[] value() default { };
+					}
+
+
+					@JsonPropertyOrder({
+						JsonProperties.CONSTANT_ONE,
+						JsonProperties.CONSTANT_TWO,
+					})
+					public record X(
+					    @JsonProperty(JsonProperties.CONSTANT_ONE) String attributeOne, // Error in this line
+					    @JsonProperty(JsonProperties.CONSTANT_TWO) String attributeTwo) {
+
+						class JsonProperties {
+
+							public static final String CONSTANT_ONE = "one";
+
+							public static final String CONSTANT_TWO = "two";
+						}
+
+						public static void main(String [] args) {
+                            System.out.println("OK!");
+                        }
+					}
+					""",
+	            },
+		"OK!");
+}
 }