Creating new method ReadConfigFS which allows users to pass use fs.FS for loading files#136
Open
Aquarthur wants to merge 3 commits into
Open
Creating new method ReadConfigFS which allows users to pass use fs.FS for loading files#136Aquarthur wants to merge 3 commits into
ReadConfigFS which allows users to pass use fs.FS for loading files#136Aquarthur wants to merge 3 commits into
Conversation
Author
|
Hey @ilyakaznacheev , would you be able to give your thoughts on the PR? Totally understand if you're too busy to at the moment :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt at implementing #135 .
Quick note: I noticed that with
parseFile, the file is opened before the filetype is validated. This PR pulls out the filetype validation and creates a new functiongetParseFuncwhich will return the appropriate parser function to run (if the filetype is supported).ReadConfigandReadConfigFSthen just keep going with the returned function.Tests were added for both
ReadConfigFSandgetParseFunc.