[FIX] feedback

Signed-off-by: Jonas Klock <jonas.klock@exxeta.com>

Author: jay-k98

example/lib/presentation/samples/pie/pie_chart_sample5.dart

@@ -48,7 +48,7 @@ class _PieChartSample5State extends State<PieChartSample5> {
     return List.generate(4, (i) {
       final isTouched = i == touchedIndex;
       final radius = 56.0;
-      final sectionOffset = isTouched ? 12.0 : 0.0;
+      final radialOffset = isTouched ? 12.0 : 0.0;
       final fontSize = isTouched ? 18.0 : 14.0;
       const shadows = [Shadow(color: Colors.black, blurRadius: 2)];
 
@@ -58,7 +58,7 @@ class _PieChartSample5State extends State<PieChartSample5> {
             value: 40,
             title: '40%',
             radius: radius,
-            sectionOffset: sectionOffset,
+            radialOffset: radialOffset,
             titleStyle: TextStyle(
               fontSize: fontSize,
               fontWeight: FontWeight.bold,
@@ -78,7 +78,7 @@ class _PieChartSample5State extends State<PieChartSample5> {
             value: 30,
             title: '30%',
             radius: radius,
-            sectionOffset: sectionOffset,
+            radialOffset: radialOffset,
             titleStyle: TextStyle(
               fontSize: fontSize,
               fontWeight: FontWeight.bold,
@@ -91,7 +91,7 @@ class _PieChartSample5State extends State<PieChartSample5> {
             value: 20,
             title: '20%',
             radius: radius,
-            sectionOffset: sectionOffset,
+            radialOffset: radialOffset,
             titleStyle: TextStyle(
               fontSize: fontSize,
               fontWeight: FontWeight.bold,
@@ -111,7 +111,7 @@ class _PieChartSample5State extends State<PieChartSample5> {
             value: 10,
             title: '10%',
             radius: radius,
-            sectionOffset: sectionOffset,
+            radialOffset: radialOffset,
             titleStyle: TextStyle(
               fontSize: fontSize,
               fontWeight: FontWeight.bold,

lib/src/chart/pie_chart/pie_chart_data.dart

@@ -157,7 +157,7 @@ class PieChartSectionData with EquatableMixin {
     Color? color,
     this.gradient,
     double? radius,
-    double? sectionOffset,
+    double? radialOffset,
     bool? showTitle,
     this.titleStyle,
     String? title,
@@ -170,7 +170,7 @@ class PieChartSectionData with EquatableMixin {
   })  : value = value ?? 10,
         color = color ?? Colors.cyan,
         radius = (radius ?? 40).clamp(0, double.infinity).toDouble(),
-        sectionOffset = sectionOffset ?? 0,
+        radialOffset = radialOffset ?? 0,
         showTitle = showTitle ?? true,
         title = title ?? (value == null ? '' : value.toString()),
         borderSide = borderSide ?? const BorderSide(width: 0),
@@ -199,7 +199,10 @@ class PieChartSectionData with EquatableMixin {
 
   /// Additional radial translation applied to the whole section (in logical pixels).
   /// Positive values move the section outward along its center angle.
-  final double sectionOffset;
+  ///
+  /// Note: This parameter is ignored when there is only a single section
+  /// occupying 360 degrees, as there is no meaningful direction to offset.
+  final double radialOffset;
 
   /// Defines show or hide the title of section.
   final bool showTitle;
@@ -250,7 +253,7 @@ class PieChartSectionData with EquatableMixin {
     Color? color,
     Gradient? gradient,
     double? radius,
-    double? sectionOffset,
+    double? radialOffset,
     bool? showTitle,
     TextStyle? titleStyle,
     String? title,
@@ -266,7 +269,7 @@ class PieChartSectionData with EquatableMixin {
         color: color ?? this.color,
         gradient: gradient ?? this.gradient,
         radius: radius ?? this.radius,
-        sectionOffset: sectionOffset ?? this.sectionOffset,
+        radialOffset: radialOffset ?? this.radialOffset,
         showTitle: showTitle ?? this.showTitle,
         titleStyle: titleStyle ?? this.titleStyle,
         title: title ?? this.title,
@@ -291,7 +294,7 @@ class PieChartSectionData with EquatableMixin {
         color: Color.lerp(a.color, b.color, t),
         gradient: Gradient.lerp(a.gradient, b.gradient, t),
         radius: lerpDouble(a.radius, b.radius, t),
-        sectionOffset: lerpDouble(a.sectionOffset, b.sectionOffset, t),
+        radialOffset: lerpDouble(a.radialOffset, b.radialOffset, t),
         showTitle: b.showTitle,
         titleStyle: TextStyle.lerp(a.titleStyle, b.titleStyle, t),
         title: b.title,
@@ -322,7 +325,7 @@ class PieChartSectionData with EquatableMixin {
         color,
         gradient,
         radius,
-        sectionOffset,
+        radialOffset,
         showTitle,
         titleStyle,
         title,

lib/src/chart/pie_chart/pie_chart_painter.dart

@@ -109,14 +109,10 @@ class PieChartPainter extends BaseChartPainter<PieChartData> {
       }
       final sectionDegree = sectionsAngle[i];
 
-      // Compute offset for "exploded" sections
       final sectionCenterAngle = tempAngle + (sectionDegree / 2);
-      final sectionOffset = section.sectionOffset;
-      final offsetDx =
-          math.cos(Utils().radians(sectionCenterAngle)) * sectionOffset;
-      final offsetDy =
-          math.sin(Utils().radians(sectionCenterAngle)) * sectionOffset;
-      final sectionCenter = center.translate(offsetDx, offsetDy);
+      final radialOffset =
+          _computeRadialOffset(section.radialOffset, sectionCenterAngle);
+      final sectionCenter = center + radialOffset;
 
       if (sectionDegree == 360) {
         final fullCirclePath = generateSegmentPath(
@@ -732,14 +728,12 @@ class PieChartPainter extends BaseChartPainter<PieChartData> {
         }
       }
 
-      final sectionOffset = section.sectionOffset;
-      final offsetDx =
-          math.cos(Utils().radians(sectionCenterAngle)) * sectionOffset;
-      final offsetDy =
-          math.sin(Utils().radians(sectionCenterAngle)) * sectionOffset;
+      final radialOffset =
+          _computeRadialOffset(section.radialOffset, sectionCenterAngle);
 
       Offset sectionCenter(double percentageOffset) =>
-          center.translate(offsetDx, offsetDy) +
+          center +
+          radialOffset +
           Offset(
             math.cos(Utils().radians(sectionCenterAngle)) *
                 (centerRadius + (section.radius * percentageOffset)),
@@ -836,20 +830,16 @@ class PieChartPainter extends BaseChartPainter<PieChartData> {
         break;
       }
 
-      // Account for outward offset when hit-testing
       final sectionCenterAngle = tempAngle + (sectionAngle / 2);
-      final sectionOffset = section.sectionOffset;
-      final offsetDx =
-          math.cos(Utils().radians(sectionCenterAngle)) * sectionOffset;
-      final offsetDy =
-          math.sin(Utils().radians(sectionCenterAngle)) * sectionOffset;
+      final radialOffset =
+          _computeRadialOffset(section.radialOffset, sectionCenterAngle);
 
       final sectionPath = generateSectionPath(
         section,
         data.sectionsSpace,
         tempAngle,
         sectionAngle,
-        center.translate(offsetDx, offsetDy),
+        center + radialOffset,
         centerRadius,
       );
 
@@ -893,14 +883,12 @@ class PieChartPainter extends BaseChartPainter<PieChartData> {
       final sectionCenterAngle = startAngle + (sweepAngle / 2);
       final centerRadius = calculateCenterRadius(viewSize, holder);
 
-      final sectionOffset = section.sectionOffset;
-      final offsetDx =
-          math.cos(Utils().radians(sectionCenterAngle)) * sectionOffset;
-      final offsetDy =
-          math.sin(Utils().radians(sectionCenterAngle)) * sectionOffset;
+      final radialOffset =
+          _computeRadialOffset(section.radialOffset, sectionCenterAngle);
 
       Offset sectionCenter(double percentageOffset) =>
-          center.translate(offsetDx, offsetDy) +
+          center +
+          radialOffset +
           Offset(
             math.cos(Utils().radians(sectionCenterAngle)) *
                 (centerRadius + (section.radius * percentageOffset)),
@@ -918,4 +906,15 @@ class PieChartPainter extends BaseChartPainter<PieChartData> {
 
     return badgeWidgetsOffsets;
   }
+
+  /// Computes the radial offset translation for a section along its center angle.
+  Offset _computeRadialOffset(
+    double radialOffset,
+    double sectionCenterAngle,
+  ) {
+    return Offset(
+      math.cos(Utils().radians(sectionCenterAngle)) * radialOffset,
+      math.sin(Utils().radians(sectionCenterAngle)) * radialOffset,
+    );
+  }
 }

repo_files/documentations/pie_chart.md

@@ -37,7 +37,7 @@ When you change the chart's state, it animates to the new state internally (usin
 |color| colors the section| Colors.red|
 |gradient| You can use any [Gradient](https://api.flutter.dev/flutter/dart-ui/Gradient-class.html) here. such as [LinearGradient](https://api.flutter.dev/flutter/painting/LinearGradient-class.html) or [RadialGradient](https://api.flutter.dev/flutter/painting/RadialGradient-class.html) (you have to provide either `color` or `gradient`)|null|
 |radius| the width radius of each section|40|
-|sectionOffset| radial translation (in logical pixels) applied to the whole section, moving it outward along its center angle. Useful for "exploded" pie charts|0|
+|radialOffset| radial translation (in logical pixels) applied to the whole section, moving it outward along its center angle. Useful for "exploded" pie charts. Ignored when there is only a single section (360 degrees)|0|
 |showTitle| determines whether to show or hide the titles on each section|true|
 |titleStyle| TextStyle of the titles| TextStyle(color: Colors.white, fontSize: 16, fontWeight: FontWeight.bold)|
 |title| title of the section| value|

test/chart/pie_chart/pie_chart_data_test.dart

@@ -278,43 +278,42 @@ void main() {
   group('PieChartSectionData', () {
     test('equality', () {
       final a =
-          PieChartSectionData(value: 10, color: Colors.red, sectionOffset: 8);
+          PieChartSectionData(value: 10, color: Colors.red, radialOffset: 8);
       final b =
-          PieChartSectionData(value: 10, color: Colors.red, sectionOffset: 8);
+          PieChartSectionData(value: 10, color: Colors.red, radialOffset: 8);
       expect(a == b, true);
 
       expect(
-        a ==
-            PieChartSectionData(value: 10, color: Colors.red, sectionOffset: 0),
+        a == PieChartSectionData(value: 10, color: Colors.red, radialOffset: 0),
         false,
       );
     });
 
     test('copyWith', () {
       final original = PieChartSectionData(value: 10, color: Colors.red);
-      expect(original.sectionOffset, 0);
+      expect(original.radialOffset, 0);
 
-      final withOffset = original.copyWith(sectionOffset: 12);
-      expect(withOffset.sectionOffset, 12);
+      final withOffset = original.copyWith(radialOffset: 12);
+      expect(withOffset.radialOffset, 12);
       expect(withOffset.value, 10);
 
       expect(original.copyWith() == original, true);
     });
 
     test('lerp', () {
       final a =
-          PieChartSectionData(value: 10, color: Colors.red, sectionOffset: 0);
+          PieChartSectionData(value: 10, color: Colors.red, radialOffset: 0);
       final b =
-          PieChartSectionData(value: 10, color: Colors.red, sectionOffset: 20);
+          PieChartSectionData(value: 10, color: Colors.red, radialOffset: 20);
 
       final atZero = PieChartSectionData.lerp(a, b, 0);
-      expect(atZero.sectionOffset, 0);
+      expect(atZero.radialOffset, 0);
 
       final atOne = PieChartSectionData.lerp(a, b, 1);
-      expect(atOne.sectionOffset, 20);
+      expect(atOne.radialOffset, 20);
 
       final mid = PieChartSectionData.lerp(a, b, 0.5);
-      expect(mid.sectionOffset, 10);
+      expect(mid.radialOffset, 10);
     });
   });
 }

test/chart/pie_chart/pie_chart_painter_test.dart

@@ -370,15 +370,15 @@ void main() {
       expect(results[3]['paint_style'] as PaintingStyle, PaintingStyle.fill);
     });
 
-    test('test 3 - sectionOffset translates section along center angle', () {
+    test('test 3 - radialOffset translates section along center angle', () {
       const viewSize = Size(200, 200);
       const centerRadius = 10.0;
       const offset = 20.0;
 
       final section0 = PieChartSectionData(
         color: MockData.color1,
         value: 1,
-        sectionOffset: offset,
+        radialOffset: offset,
       );
       final section1 = PieChartSectionData(
         color: MockData.color2,