Line chart appear animation#1994
Closed
Michal-MK wants to merge 5 commits intoimaNNeo:mainfrom
Closed
Conversation
Owner
|
Hi, thanks for your PR and for implementing the loading animation. To be honest, I don't think this solution is scalable and customizable.
And now there are a lot of conflicts. So I'll close it for now. Thanks again! |
Author
|
Oh hey this PR existed :D No worries, maybe you can take something from it and implement it better. |
Owner
|
Haha! Thanks for your contribution btw, it definitely gives some idea to me (and my LLM :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly closing #1223 as we also had this issue in our project so I implemented this and now ported it to newest fl_chart to see if it can be merged.
2025-09-10.23-13-03.mp4
So far no tests and no coverage stuff (I read the contributors guide :D)
If this is accepted as a solution I will look at that and address it in the PR.