Skip to content

Commit 1e5b550

Browse files
committed
Remove color overrides from notice include
They mess up accessibility scans.
1 parent 1856fec commit 1e5b550

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

_includes/notice

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ Adds a stylized notice.
1919

2020
{%- comment -%}
2121
Background and border colors are handled by CSS via the notice-{{icon}} class.
22-
Only apply inline overrides when explicit colors are passed as include params.
2322
{%- endcomment -%}
2423
{%- assign notice-icon-class = icon | default: "default" | strip -%}
2524
{%- if notice-icon-class == "" -%}{%- assign notice-icon-class = "default" -%}{%- endif -%}
2625
{%- capture font-size-style -%}{%- if notice-size -%}font-size: {{notice-size}}; {%- endif -%}{%- endcapture -%}
27-
{%- capture inline-style -%}{{font-size-style}}{%- if include.background-color -%}background: {{include.background-color}}; {%- endif -%}{%- if include.highlight-color -%}border-left-color: {{include.highlight-color}}; {%- endif -%}{%- endcapture -%}
28-
<div class="notice notice-{{notice-icon-class}}" style="{{inline-style}}">
26+
<div class="notice notice-{{notice-icon-class}}" style="{{font-size-style}}">
2927
{%- if glyph != "" or glyph-classes != "" -%}
3028
<div class="notice-icon"><span class="{{glyph-classes}}">{{glyph}}</span></div>
3129
{%- elsif icon and icon != "" -%}

_pages/plugins/snt/strahler.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ There are several entry points to Strahler Analysis in SNT. You can find those i
3232
{% capture strahler%}
3333
While _Strahler Analysis (Image)..._ remains a functional workflow, you may find its simplicity rather limiting. A more flexible approach may be to run [auto-tracing](/plugins/snt/auto-tracing) and run [Strahler Analysis (Tracings)](/plugins/snt/analysis#strahler-analysis) on them.
3434
{% endcapture %}
35-
{% include notice icon="warning" background-color="#fffbeb" content=strahler %}
35+
{% include notice icon="note" content=strahler %}
3636

3737
{% include img align="right" src="/media/plugins/snt/strahler-classification-example.png" caption="Strahler classification"%}
3838
Strahler numbering is a numerical procedure that summarizes the branching complexity of mathematical trees. It is described in detail [here](./analysis#strahler-analysis).

_pages/plugins/snt/walkthroughs.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ The legacy 3D Viewer allows for tracing in an interactive 3D scene.
167167

168168
- Options in the _Mode_ drop-down menu specify how paths should be rendered. There are three possibilities: 1) *Lines*: Only the centerline of paths is displayed; 2) *Lines and disks*: Centerline of paths is displayed with disks at each node depicting the node radius; and 3) *Surface reconstruction*: Paths are displayed as surface meshes.
169169

170-
{% include notice highlight-color="#67A1FE" background-color="#EBF2F8" content="It is recommended to render color coded paths in either [Reconstruction Plotter](./manual#reconstruction-plotter) or [Reconstruction Viewer](./reconstruction-viewer) because the algorithms that allow paths to be [mapped to lookup tables ](./manual#color-mapping-) have not been ported to the Legacy 3D Viewer." %}
170+
{% include notice icon="info" content="It is recommended to render color coded paths in either [Reconstruction Plotter](./manual#reconstruction-plotter) or [Reconstruction Viewer](./reconstruction-viewer) because the algorithms that allow paths to be [mapped to lookup tables ](./manual#color-mapping-) have not been ported to the Legacy 3D Viewer." %}
171171

172172
### II. Tracing and Navigation
173173
<img align="right" src="/media/plugins/snt/snt-legacy-3d-viewer.png" title="3D viewer showing OP_1.tif" width="350"/>

0 commit comments

Comments
 (0)