Skip to content

Commit efd08ce

Browse files
committed
chore: enhance CI workflow with SDK build verification and update Playwright server command
1 parent c051198 commit efd08ce

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,14 @@ jobs:
3131
- name: Build SDK
3232
run: npm run build
3333

34+
- name: Verify SDK build
35+
run: |
36+
if [ ! -d "dist/imagekit-angular" ]; then
37+
echo "Error: SDK build directory not found"
38+
exit 1
39+
fi
40+
echo "✓ SDK built successfully"
41+
3442
- name: Install test app dependencies
3543
working-directory: ./test-app
3644
run: npm ci

test-app/playwright.config.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ export default defineConfig({
3131
// Run your local dev server before starting the tests:
3232
// https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests
3333
webServer: {
34-
command: "npm start",
34+
command: `npm start -- --port ${PORT}`,
3535
url: baseURL,
3636
timeout: 120 * 1000,
37-
// @ts-ignore
38-
reuseExistingServer: !process.env.CI,
37+
reuseExistingServer: !process.env['CI'],
38+
// Show output in CI for debugging server startup issues
39+
// Playwright will poll the URL until it gets a successful HTTP response (200 OK)
3940
},
4041

4142
use: {

0 commit comments

Comments
 (0)