Skip to content

Commit fb40aeb

Browse files
committed
chore: update TypeScript configuration and refine Playwright testing setup
- Set "skipLibCheck" to false in tsconfig.json for stricter type checking. - Simplify e2e workflow by limiting the project matrix to "Desktop Chrome" only. - Increase timeout settings in Playwright configuration for tests and assertions. - Adjust Playwright test command to remove unnecessary project specification.
1 parent efd08ce commit fb40aeb

4 files changed

Lines changed: 10 additions & 25 deletions

File tree

.github/workflows/e2e.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
project: ['Desktop Chrome', 'Desktop Firefox', 'Desktop Safari']
16+
project: ['Desktop Chrome']
1717

1818
steps:
1919
- name: Checkout code
@@ -45,8 +45,7 @@ jobs:
4545
# Note: Playwright browsers are installed via postinstall script
4646

4747
- name: Run Playwright tests
48-
working-directory: ./test-app
49-
run: npm run test:e2e -- --project="${{ matrix.project }}"
48+
run: npm run test:e2e"
5049

5150
- name: Upload test results on failure
5251
if: failure()

test-app/playwright.config.ts

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ const baseURL = `http://localhost:${PORT}`;
1111
// Reference: https://playwright.dev/docs/test-configuration
1212
export default defineConfig({
1313
// Timeout per test
14-
timeout: 30 * 1000,
14+
timeout: 100000,
1515
// Global timeout for the entire test run (prevents infinite stalling)
1616
globalTimeout: 60 * 60 * 1000, // 60 minutes
1717
// Expect timeout for assertions
1818
expect: {
19-
timeout: 5 * 1000, // 5 seconds
19+
timeout: 10 * 1000, // 5 seconds
2020
},
2121
// Test directory
2222
testDir: path.join(__dirname, "e2e"),
@@ -35,7 +35,8 @@ export default defineConfig({
3535
url: baseURL,
3636
timeout: 120 * 1000,
3737
reuseExistingServer: !process.env['CI'],
38-
// Show output in CI for debugging server startup issues
38+
stdout: 'pipe',
39+
stderr: 'pipe',
3940
// Playwright will poll the URL until it gets a successful HTTP response (200 OK)
4041
},
4142

@@ -60,30 +61,15 @@ export default defineConfig({
6061
use: {
6162
...devices["Desktop Chrome"],
6263
},
63-
},
64-
{
65-
name: "Desktop Firefox",
66-
use: {
67-
...devices["Desktop Firefox"],
68-
},
69-
},
70-
{
71-
name: "Desktop Safari",
72-
use: {
73-
...devices["Desktop Safari"],
74-
},
64+
7565
},
7666
// Test against mobile viewports.
7767
{
7868
name: "Mobile Chrome",
7969
use: {
8070
...devices["Pixel 5"],
8171
},
82-
},
83-
{
84-
name: "Mobile Safari",
85-
use: devices["iPhone 12"],
86-
},
72+
}
8773
],
8874
});
8975

test-app/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"target": "ES2022",
2020
"module": "ES2022",
2121
"useDefineForClassFields": false,
22-
"skipLibCheck": true,
22+
"skipLibCheck": false,
2323
"lib": [
2424
"ES2022",
2525
"dom"

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"target": "ES2022",
2020
"module": "ES2022",
2121
"useDefineForClassFields": false,
22-
"skipLibCheck": true,
22+
"skipLibCheck": false,
2323
"lib": [
2424
"ES2022",
2525
"dom"

0 commit comments

Comments
 (0)