Skip to content

Commit 3483b4c

Browse files
committed
chore(video-player): remove README.md from imagekit-signer-server and update package.json for module resolution
1 parent 99dd5fa commit 3483b4c

3 files changed

Lines changed: 22 additions & 124 deletions

File tree

imagekit-signer-server/README.md

Lines changed: 0 additions & 121 deletions
This file was deleted.

packages/video-player/javascript/modules/chapters/chapters.ts

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,11 +194,18 @@ function setupSubtitleChapterSync(player: Player): void {
194194
}
195195

196196
const handler = () => {
197+
// Get fresh reference to textTracks inside handler to avoid stale references
198+
// when source changes and textTracks are cleared/reset
199+
const currentTextTracks = player.textTracks();
200+
if (!currentTextTracks) {
201+
return;
202+
}
203+
197204
let foundActiveTrack = false;
198205

199206
// Check for active subtitle track
200207
// TextTrackList is array-like, iterate using index access
201-
const textTracksList = textTracks as unknown as TextTrack[];
208+
const textTracksList = currentTextTracks as unknown as TextTrack[];
202209
for (let i = 0; i < textTracksList.length; i++) {
203210
const track = textTracksList[i];
204211

@@ -265,6 +272,7 @@ function setupChapterLabelDisplay(player: Player, chaptersTrack: TextTrack): voi
265272
perChapterCleanup = new CleanupRegistry();
266273
}
267274
perChapterCleanup.registerEventListener(chaptersTrack, 'cuechange', cueChangeHandler);
275+
cueChangeHandler();
268276
}
269277

270278
/**
@@ -293,6 +301,18 @@ export async function initChapterMarkers(
293301

294302
let chapterList: ChapterMarker[] = [];
295303

304+
function waitForLoadedMetadata(player: Player): Promise<void> {
305+
return new Promise((resolve) => {
306+
if (player.readyState() > 0) {
307+
resolve();
308+
return;
309+
}
310+
player.one('loadedmetadata', () => resolve());
311+
});
312+
}
313+
314+
await waitForLoadedMetadata(player);
315+
296316
if (typeof src.chapters === 'object' && 'url' in src.chapters) {
297317
// Manual VTT URL - load directly
298318
try {

packages/video-player/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
".": {
1212
"types": "./dist/index.d.ts",
1313
"import": "./dist/index.mjs",
14-
"require": "./dist/index.js",
15-
"browser": "./dist/index.global.js"
14+
"require": "./dist/index.js"
1615
},
1716
"./react": {
1817
"types": "./dist/react/index.d.ts",

0 commit comments

Comments
 (0)