Skip to content

Commit 4d33265

Browse files
committed
fix: re-add windows-11-arm, update mozjpeg-sys, remove LLVM steps
- Update mozjpeg-sys 2.0.2 -> 2.2.3 (fixes ARM NEON assembly on Windows) - Re-add windows-11-arm to CI matrix - Remove LLVM/libclang install steps (no crate in dep tree uses bindgen)
1 parent 36ec769 commit 4d33265

2 files changed

Lines changed: 4 additions & 18 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@ jobs:
1919
lib-name: libimageflow_node.dylib
2020
- os: windows-latest
2121
lib-name: imageflow_node.dll
22-
# windows-11-arm: blocked — mozjpeg-sys NEON assembly (.S)
23-
# uses GNU as syntax which MSVC cl.exe can't compile.
24-
# Needs upstream fix in mozjpeg-sys to use clang-cl or MASM.
22+
- os: windows-11-arm
23+
lib-name: imageflow_node.dll
2524

2625
runs-on: ${{ matrix.os }}
2726

@@ -47,19 +46,6 @@ jobs:
4746
restore-keys: |
4847
${{ runner.os }}-${{ runner.arch }}-cargo-
4948
50-
- name: Install LLVM (Linux)
51-
if: runner.os == 'Linux'
52-
run: sudo apt-get install -y llvm libclang-dev
53-
54-
- name: Install LLVM (Windows)
55-
if: runner.os == 'Windows'
56-
run: choco install -y llvm
57-
58-
- name: Set LLVM path (Windows)
59-
if: runner.os == 'Windows'
60-
shell: bash
61-
run: echo "LIBCLANG_PATH=C:\Program Files\LLVM\bin" >> $GITHUB_ENV
62-
6349
- name: Build native module
6450
working-directory: native
6551
run: cargo build

native/Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)