Build: usage of enable_lto, improve clang tidy usage, clean compileopt

Author: imbobz

CMakeLists.txt

@@ -12,6 +12,7 @@ list(APPEND CMAKE_MODULE_PATH "${PROJECT_SOURCE_DIR}/cmake/modules")
 option(CAE_BUILD_DOC_HTML "Build html documentation" OFF)
 option(CAE_BUILD_DOC_PDF "Build pdf documentation" OFF)
 option(CAE_CLANG_FORMAT "Enable clang-format" OFF)
+option(CAE_CLANG_TIDY "Enable clang-tidy static analysis" OFF)
 
 file(GLOB_RECURSE PROJECT_FILES
         ${SOURCES}
@@ -34,6 +35,10 @@ if (CAE_CLANG_FORMAT)
     format_project(${PROJECT_FILES})
 endif ()
 
+if (CAE_CLANG_TIDY)
+    run_clang_tidy(${PROJECT_FILES})
+endif ()
+
 if (CAE_BUILD_DOC_HTML)
     cae_add_doxygen_html(cae-doc-html ${PROJECT_FILES})
 elseif (CAE_BUILD_DOC_PDF)

apps/Editor/CMakeLists.txt

@@ -11,6 +11,10 @@ file(GLOB_RECURSE SOURCES CONFIGURE_DEPENDS "${PROJECT_SOURCE_DIR}/src/*.cpp")
 
 add_executable(${PROJECT_NAME} ${SOURCES})
 
+if (CAE_ENABLE_LTO)
+    cae_enable_lto(${PROJECT_NAME})
+endif ()
+
 target_compile_definitions(${PROJECT_NAME} PRIVATE PLUGINS_DIR="${CMAKE_BINARY_DIR}/bin/lib")
 
 target_include_directories(${PROJECT_NAME} PRIVATE

cmake/modules/ClangFormat.cmake

@@ -1,16 +1,14 @@
 function(format_project FILES_TO_FORMAT)
-
     find_program(CLANG_FORMAT_EXE NAMES clang-format REQUIRED)
 
-    add_custom_target(${PROJECT_NAME}-clang-format
+    add_custom_target("${PROJECT_NAME}-clang-format"
             COMMAND ${CLANG_FORMAT_EXE} -style=file -i ${FILES_TO_FORMAT}
             WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
             COMMENT "Formatting sources with clang-format"
     )
-    add_custom_target(${PROJECT_NAME}-clang-format-check
+    add_custom_target("${PROJECT_NAME}-clang-format-check"
             COMMAND ${CLANG_FORMAT_EXE} --dry-run --Werror -style=file ${FILES_TO_FORMAT}
             WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
             COMMENT "Checking source formatting"
     )
-
 endfunction()

cmake/modules/ClangTidy.cmake

@@ -1,10 +1,5 @@
-option(CAE_CLANG_TIDY "Enable clang-tidy static analysis" OFF)
-
-if (NOT CAE_CLANG_TIDY)
-    return()
-endif()
-
-find_program(CLANG_TIDY_EXE NAMES "clang-tidy" REQUIRED)
-
-set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXE};-header-filter=${CMAKE_SOURCE_DIR}/src")
-set_source_files_properties(${SOURCES} PROPERTIES CXX_CLANG_TIDY "${CMAKE_CXX_CLANG_TIDY}")
+function(run_clang_tidy FILES)
+    find_program(CLANG_TIDY_EXE NAMES "clang-tidy" REQUIRED)
+    set(CMAKE_CXX_CLANG_TIDY "${CLANG_TIDY_EXE};-header-filter=${CMAKE_SOURCE_DIR}/src")
+    set_source_files_properties(${FILES} PROPERTIES CXX_CLANG_TIDY "${CMAKE_CXX_CLANG_TIDY}")
+endfunction()

cmake/modules/CompileOptions.cmake

@@ -1,12 +1,14 @@
-add_library(cae-compile-options INTERFACE)
+set(TARGET_NAME "${TARGET_NAME}")
 
-target_compile_features(cae-compile-options INTERFACE cxx_std_23)
+add_library(${TARGET_NAME} INTERFACE)
+
+target_compile_features(${TARGET_NAME} INTERFACE cxx_std_23)
 
 option(CAE_STRICT_WARNINGS "Enable strict warning level" OFF)
 option(CAE_ENABLE_SANITIZERS "Enable address and undefined sanitizers" OFF)
 option(CAE_ENABLE_LTO "Enable LTO on final targets" OFF)
 
-target_compile_options(cae-compile-options INTERFACE
+target_compile_options(${TARGET_NAME} INTERFACE
         # Strict warnings
         $<$<AND:$<CXX_COMPILER_ID:GNU,Clang,AppleClang>,$<BOOL:${CAE_STRICT_WARNINGS}>,$<NOT:$<PLATFORM_ID:Android,Emscripten,iOS>>>:
         -Wall
@@ -45,68 +47,68 @@ target_compile_options(cae-compile-options INTERFACE
 )
 
 # GCC / Clang
-target_compile_options(cae-compile-options INTERFACE
+target_compile_options(${TARGET_NAME} INTERFACE
         $<$<AND:$<CONFIG:RelWithDebInfo>,$<CXX_COMPILER_ID:GNU,Clang,AppleClang>>:-O2>
         $<$<AND:$<CONFIG:Debug>,$<CXX_COMPILER_ID:GNU,Clang,AppleClang>>:-O0 -g>
 )
 
 # MSVC
-target_compile_options(cae-compile-options INTERFACE
+target_compile_options(${TARGET_NAME} INTERFACE
         $<$<AND:$<CONFIG:Release>,$<CXX_COMPILER_ID:MSVC>>:/O2>
         $<$<AND:$<CONFIG:RelWithDebInfo>,$<CXX_COMPILER_ID:MSVC>>:/O2 /Zi>
         $<$<AND:$<CONFIG:Debug>,$<CXX_COMPILER_ID:MSVC>>:/Od /Zi>
 )
 
-target_compile_definitions(cae-compile-options INTERFACE
+target_compile_definitions(${TARGET_NAME} INTERFACE
         $<$<CONFIG:Debug>:
         CAE_DEBUG
         >
 )
 
 if(CAE_ENABLE_SANITIZERS)
-    target_compile_options(cae-compile-options INTERFACE
+    target_compile_options(${TARGET_NAME} INTERFACE
             $<$<AND:$<CXX_COMPILER_ID:GNU,Clang>,$<NOT:$<PLATFORM_ID:Android,Emscripten,Windows>>>:
             -fsanitize=address,undefined
             >
     )
-    target_link_options(cae-compile-options INTERFACE
+    target_link_options(${TARGET_NAME} INTERFACE
             $<$<AND:$<CXX_COMPILER_ID:GNU,Clang>,$<NOT:$<PLATFORM_ID:Android,Emscripten,Windows>>>:
             -fsanitize=address,undefined
             >
     )
 endif()
 
-function(cae_enable_lto target)
+function(cae_enable_lto TARGET)
     if (CAE_ENABLE_LTO)
         include(CheckIPOSupported)
         check_ipo_supported(RESULT CAE_LTO_SUPPORTED OUTPUT CAE_LTO_ERROR)
         if (CAE_LTO_SUPPORTED)
-            set_property(TARGET ${target} PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)
+            set_property(TARGET ${TARGET} PROPERTY INTERPROCEDURAL_OPTIMIZATION TRUE)
         else()
             message(WARNING "CAE: LTO not supported: ${CAE_LTO_ERROR}")
         endif()
     endif()
 endfunction()
 
 if (EMSCRIPTEN)
-    target_compile_definitions(cae-compile-options INTERFACE
+    target_compile_definitions(${TARGET_NAME} INTERFACE
             CAE_PLATFORM_WEB
     )
 elseif (ANDROID)
-    target_compile_definitions(cae-compile-options INTERFACE CAE_PLATFORM_ANDROID)
+    target_compile_definitions(${TARGET_NAME} INTERFACE CAE_PLATFORM_ANDROID)
 elseif (APPLE)
     if (IOS)
-        target_compile_definitions(cae-compile-options INTERFACE CAE_PLATFORM_IOS)
+        target_compile_definitions(${TARGET_NAME} INTERFACE CAE_PLATFORM_IOS)
     else()
-        target_compile_definitions(cae-compile-options INTERFACE CAE_PLATFORM_MACOS)
+        target_compile_definitions(${TARGET_NAME} INTERFACE CAE_PLATFORM_MACOS)
     endif()
 elseif (WIN32)
-    target_compile_definitions(cae-compile-options INTERFACE
+    target_compile_definitions(${TARGET_NAME} INTERFACE
             CAE_PLATFORM_WINDOWS
             NOMINMAX
             WIN32_LEAN_AND_MEAN
     )
 elseif (UNIX)
-    target_compile_definitions(cae-compile-options INTERFACE CAE_PLATFORM_LINUX)
+    target_compile_definitions(${TARGET_NAME} INTERFACE CAE_PLATFORM_LINUX)
 endif()
 

cmake/modules/CopyAssets.cmake

@@ -3,7 +3,7 @@ function(copy_directory_to_target TARGET SRC_DIR DST_SUBDIR)
         message(FATAL_ERROR "Target '${TARGET}' does not exist")
     endif()
 
-    set(COPY_TARGET_NAME ${TARGET}-copy-assets)
+    set(COPY_TARGET_NAME "${TARGET}-copy-assets")
 
     set(DST_DIR "$<TARGET_FILE_DIR:${TARGET}>/${DST_SUBDIR}")
 

modules/Engine/CMakeLists.txt

@@ -12,6 +12,10 @@ file(GLOB_RECURSE HEADERS "${INCLUDE_DIR}/Engine/*.hpp")
 
 add_library(${PROJECT_NAME} STATIC)
 
+if (CAE_ENABLE_LTO)
+    cae_enable_lto(${PROJECT_NAME})
+endif ()
+
 target_sources(${PROJECT_NAME}
         PRIVATE ${SOURCES}
         PUBLIC FILE_SET HEADERS

modules/Utils/CMakeLists.txt

@@ -22,6 +22,10 @@ FetchContent_MakeAvailable(stb)
 
 add_library(${PROJECT_NAME} STATIC)
 
+if (CAE_ENABLE_LTO)
+    cae_enable_lto(${PROJECT_NAME})
+endif ()
+
 target_sources(${PROJECT_NAME}
         PRIVATE ${SOURCES}
         PUBLIC FILE_SET HEADERS