Skip to content

Validate slice count before subtraction #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehrenfeu merged 3 commits into from
Jan 19, 2026
Merged

Validate slice count before subtraction #117

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
401b3c5
fix(image): validate slice count before subtraction
lguerard Dec 8, 2025
0a46264
fix(image): set calibration for subtracted images
lguerard Dec 8, 2025
73268dd
fix(image): raise ValueError for slice count mismatch in subtraction
lguerard Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/imcflibs/imagej/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,14 @@ def subtract_images(imp1, imp2):
The ImagePlus resulting from the subtraction.
"""
ic = ImageCalculator()
subtracted = ic.run("Subtract create", imp1, imp2)
if imp1.getNSlices() != imp2.getNSlices():
sys.exit(
"Cannot subtract images with different number of slices, "
"please check your input data."
)
option = " stack" if imp1.getNSlices() > 1 else ""
subtracted = ic.run("Subtract create" + option, imp1, imp2)
subtracted.setCalibration(imp1.getCalibration())

return subtracted

Expand Down
Loading