Skip to content

Fix/129 bdv variable type mixup #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehrenfeu merged 4 commits into from
Jan 19, 2026
Merged

Fix/129 bdv variable type mixup #131

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
263dd33
fix(bdv): correct channel_source default value and error handling
lguerard Jan 19, 2026
d02ebcf
Update error message for invalid transformation type
ehrenfeu Jan 19, 2026
7ca1652
Merge branch 'devel' into fix/129_bdv_variable_type_mixup
ehrenfeu Jan 19, 2026
ec9ab9e
Merge back readability changes from commit b8ff579
ehrenfeu Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/imcflibs/imagej/bdv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from .. import pathtools
from ..log import LOG as log


# internal template strings used in string formatting (note: the `"""@private"""`
# pseudo-decorator is there to instruct [pdoc] to omit those variables when generating
# API documentation):
Expand Down Expand Up @@ -1373,7 +1372,7 @@ def interest_points_registration(
def duplicate_transformations(
project_path,
transformation_type="channel",
channel_source=None,
channel_source=0,
tile_source=None,
transformation_to_use="[Replace all transformations]",
):
Expand Down Expand Up @@ -1412,7 +1411,10 @@ def duplicate_transformations(
if transformation_type == "channel":
apply = "[One channel to other channels]"
target = "[All Channels]"
source = str(channel_source - 1)
if channel_source > 0:
source = str(channel_source - 1)
else:
source = "0"
if tile_source:
tile_apply = "apply_to_tile=[Single tile (Select from List)] "
tile_process = "processing_tile=[tile " + str(tile_source) + "] "
Expand All @@ -1422,15 +1424,15 @@ def duplicate_transformations(
apply = "[One tile to other tiles]"
target = "[All Tiles]"
source = str(tile_source)
if channel_source:
if channel_source > 0:
chnl_apply = "apply_to_channel=[Single channel (Select from List)] "
chnl_process = (
"processing_channel=[channel " + str(channel_source - 1) + "] "
)
else:
chnl_apply = "apply_to_channel=[All channels] "
else:
sys.exit("Issue with transformation duplication")
raise ValueError("Issue with transformation duplication")

options = (
"apply="
Expand Down
Loading