Skip to content

Fix bug at UTF-8 space at "%20" #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morteerror404 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix bug at UTF-8 space at "%20" #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a7af34
first try fix
morteerror404 May 21, 2026
e084cd9
i miss the >
morteerror404 May 21, 2026
9ae94db
Final push
morteerror404 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions lib/summary/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,36 +83,30 @@ function Summary(options) {
function work(filesObj) {
_.forEach(filesObj, function(n, key) {
if (!_.includes(ignores, key)) {
if (_.isObject(n)) {
var formatLink = function(pathStr) {
var cleanPath = pathStr.replace(/[)\n\r]/g, '');
return "<" + cleanPath + ">)";
};

// It means folderName == subFileName, for example: */assets/assets.md or */Assets/assets.md
if (_.isObject(n)) {
if (_.isString(n[key]) || _.isString(n[key.toLowerCase()])) {
var file = n[key] || n[key.toLowerCase()];
desc += _.repeat(' ', step) + formatCatalog(key, '-') + file;

// Mark it to skip
desc += _.repeat(' ', step) + formatCatalog(key, '-') + formatLink(file) + "\n";
skip = key;
}

// The file is `readme.md`
else if (_.isString(n['readme']) || _.isString(n['Readme']) || _.isString(n['README'])) {
var readmeDir = n['readme'] || n['Readme'] || n['README'];
desc += _.repeat(' ', step) + formatCatalog(key, '-') + readmeDir.replace(/ /g, "%20");
desc += _.repeat(' ', step) + formatCatalog(key, '-') + formatLink(readmeDir) + "\n";
} else {
desc += _.repeat(' ', step) + "- " + prettyCatalogName(key) + "\n";
}

// Start a loop
step += 2;
work(n);
step -= 2;
} else {
// Skip if `skip` exists or key == `readme`
if (isSkiped(key, skip)) {
return;
}

desc += _.repeat(' ', step) + formatCatalog(key) + n.replace(/ /g, "%20");
if (isSkiped(key, skip)) return;

desc += _.repeat(' ', step) + formatCatalog(key) + formatLink(n) + "\n";
}
}
});
Expand Down
Loading