Add pdf and jxl formats#59
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for two new formats—JPEG XL (jxl) and PDF (pdf)—to imgproxy-js-core.
- Extended the SkipProcessing and Format type definitions to include
jxlandpdf. - Updated the options validators in
src/optionsso thatjxlandpdfare recognized. - Added a changeset entry to document the new formats.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/skipProcessing.ts | Added "jxl" to the SkipProcessing union |
| src/types/format.ts | Updated doc comments and added "jxl"/"pdf" to Format |
| src/options/skipProcessing.ts | Included "jxl" in the extNames validation array |
| src/options/format.ts | Added jxl and pdf keys to the formatValues map |
| .changeset/lovely-streets-write.md | Documented the addition of pdf and jxl formats |
Comments suppressed due to low confidence (2)
src/options/skipProcessing.ts:9
- Add unit tests to cover the new
jxlextension inskipProcessingso that validation and parsing behave as expected.
"jxl",
src/options/format.ts:16
- Add or update unit tests for
jxlandpdfin theformatValuesvalidation to ensure both formats are correctly accepted and handled.
pdf: true,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.