Fix updated pfdl messages#5
Open
maxhoerstr wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
OliverStolzBO
left a comment
OliverStolzBO
left a comment
There was a problem hiding this comment.
The naming also needs to be adjusted for the Postman testfile (https://github.com/iml130/swap-it-dashboard/blob/fix-updated-pfdl-messages/test/Dashboard%20API%20Test.postman_collection.json)
Maybe let's briefly discuss whether it makes sense to transfer the PFDL naming convention to the dashboard and uniformly rename all ids into uuids for consistency. Since the petriNetInfos of an Order are always created with messages which contain "order_uuids", I would prefer this solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename pfdl message field from order_id to order_uuid