Skip to content

Commit 33d49e5

Browse files
authored
Introduces lighting (#146)
Added the environmentMap attribute and environmentMapReady promise to the IDL, Added initial language about the use of a PBR shading model and IBL. fixes 48 fixes 47
1 parent ee03ade commit 33d49e5

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

index.html

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,8 +384,12 @@ <h2>
384384
readonly attribute Promise&lt;HTMLModelElement&gt; ready;
385385
readonly attribute DOMPointReadOnly boundingBoxCenter;
386386
readonly attribute DOMPointReadOnly boundingBoxExtents;
387+
387388
attribute DOMMatrixReadOnly entityTransform;
388389

390+
attribute USVString environmentMap;
391+
readonly attribute <span data-x="idl-Promise">Promise</span>&lt;undefined> <span data-x="dom-model-environmentMapReady">environmentMapReady</span>;
392+
389393
[Reflect=stagemode] attribute DOMString stageMode;
390394
};
391395
</pre>
@@ -425,10 +429,14 @@ <h2>
425429
<h2>
426430
Rendering
427431
</h2>
432+
<p>The model SHOULD be rendered according to a realtime, physically-based rendering (PBR) shading model, and lit by an image-based light.</p>
433+
434+
<h3>Environment map</h3>
435+
<p>If provided, an environment map MUST be interpreted as an equirectangular environment map. If an environmentMap is not specified, the User Agent MUST provide an appropriate map.</p>
436+
437+
428438
<aside class="issue" data-number="1"></aside>
429439
<aside class="issue" data-number="5"></aside>
430-
<aside class="issue" data-number="48"></aside>
431-
<aside class="issue" data-number="47"></aside>
432440
<h3>
433441
Orientation/camera
434442
</h3>
@@ -471,6 +479,7 @@ <h3>
471479
<h2>
472480
Events
473481
</h2>
482+
<p> The <code data-x="dom-model-environmentMapReady">environmentMapReady</code> <code data-x="idl-Promise">Promise</code> resolves when an environment map resource has been loaded, or is rejected if the resource is unable to be loaded.</p>
474483
<p>
475484
The [^model^] element emits a <code>ready</code> <span data-x="idl-Promise">Promise</span> when the model is processed and ready to display. The Promise is rejected if the model source cannot be loaded.
476485
</p>

0 commit comments

Comments
 (0)