transpile: Use raw pointers for lvalues with side effects

Author: Rua

c2rust-transpile/src/translator/named_references.rs

@@ -127,11 +127,12 @@ impl<'c> Translation<'c> {
                     .borrow_mut()
                     .pick_name("c2rust_lhs_side_effects");
 
-                // let ref mut p = lhs;
+                // let p = &raw mut lhs;
+                self.use_feature("raw_ref_op");
                 let compute_ref = mk().local_stmt(Box::new(mk().local(
-                    mk().mutbl().ident_ref_pat(&ptr_name),
+                    mk().ident_pat(&ptr_name),
                     None,
-                    Some(reference),
+                    Some(mk().mutbl().raw_borrow_expr(reference)),
                 )));
 
                 let write =

c2rust-transpile/tests/snapshots/snapshots__transpile@exprs.c.2021.clang15.snap

@@ -79,17 +79,17 @@ pub unsafe extern "C" fn inc_decl_with_lvalue_side_effect() {
     *lvalue_side_effect() -= 1;
     *lvalue_side_effect() += 1;
     *lvalue_side_effect() -= 1;
-    let ref mut c2rust_lhs_side_effects = *lvalue_side_effect();
+    let c2rust_lhs_side_effects = &raw mut *lvalue_side_effect();
     *c2rust_lhs_side_effects += 1;
     let mut pre_inc: ::core::ffi::c_int = *c2rust_lhs_side_effects;
-    let ref mut c2rust_lhs_side_effects_0 = *lvalue_side_effect();
+    let c2rust_lhs_side_effects_0 = &raw mut *lvalue_side_effect();
     *c2rust_lhs_side_effects_0 -= 1;
     let mut pre_dec: ::core::ffi::c_int = *c2rust_lhs_side_effects_0;
-    let ref mut c2rust_lhs_side_effects_1 = *lvalue_side_effect();
+    let c2rust_lhs_side_effects_1 = &raw mut *lvalue_side_effect();
     let c2rust_fresh2 = *c2rust_lhs_side_effects_1;
     *c2rust_lhs_side_effects_1 = *c2rust_lhs_side_effects_1 + 1;
     let mut post_inc: ::core::ffi::c_int = c2rust_fresh2;
-    let ref mut c2rust_lhs_side_effects_2 = *lvalue_side_effect();
+    let c2rust_lhs_side_effects_2 = &raw mut *lvalue_side_effect();
     let c2rust_fresh3 = *c2rust_lhs_side_effects_2;
     *c2rust_lhs_side_effects_2 = *c2rust_lhs_side_effects_2 - 1;
     let mut post_dec: ::core::ffi::c_int = c2rust_fresh3;

c2rust-transpile/tests/snapshots/snapshots__transpile@exprs.c.2024.clang15.snap

@@ -79,17 +79,17 @@ pub unsafe extern "C" fn inc_decl_with_lvalue_side_effect() {
     *lvalue_side_effect() -= 1;
     *lvalue_side_effect() += 1;
     *lvalue_side_effect() -= 1;
-    let ref mut c2rust_lhs_side_effects = *lvalue_side_effect();
+    let c2rust_lhs_side_effects = &raw mut *lvalue_side_effect();
     *c2rust_lhs_side_effects += 1;
     let mut pre_inc: ::core::ffi::c_int = *c2rust_lhs_side_effects;
-    let ref mut c2rust_lhs_side_effects_0 = *lvalue_side_effect();
+    let c2rust_lhs_side_effects_0 = &raw mut *lvalue_side_effect();
     *c2rust_lhs_side_effects_0 -= 1;
     let mut pre_dec: ::core::ffi::c_int = *c2rust_lhs_side_effects_0;
-    let ref mut c2rust_lhs_side_effects_1 = *lvalue_side_effect();
+    let c2rust_lhs_side_effects_1 = &raw mut *lvalue_side_effect();
     let c2rust_fresh2 = *c2rust_lhs_side_effects_1;
     *c2rust_lhs_side_effects_1 = *c2rust_lhs_side_effects_1 + 1;
     let mut post_inc: ::core::ffi::c_int = c2rust_fresh2;
-    let ref mut c2rust_lhs_side_effects_2 = *lvalue_side_effect();
+    let c2rust_lhs_side_effects_2 = &raw mut *lvalue_side_effect();
     let c2rust_fresh3 = *c2rust_lhs_side_effects_2;
     *c2rust_lhs_side_effects_2 = *c2rust_lhs_side_effects_2 - 1;
     let mut post_dec: ::core::ffi::c_int = c2rust_fresh3;