transpile: Use raw pointers for lvalues with side effects

Author: Rua

c2rust-transpile/src/translator/named_references.rs

@@ -124,11 +124,12 @@ impl<'c> Translation<'c> {
 
                 let ptr_name = self.renamer.borrow_mut().fresh();
 
-                // let ref mut p = lhs;
+                // let p = &raw mut lhs;
+                self.use_feature("raw_ref_op");
                 let compute_ref = mk().local_stmt(Box::new(mk().local(
-                    mk().mutbl().ident_ref_pat(&ptr_name),
+                    mk().ident_pat(&ptr_name),
                     None,
-                    Some(reference),
+                    Some(mk().mutbl().raw_borrow_expr(reference)),
                 )));
 
                 let write =

c2rust-transpile/tests/snapshots/snapshots__transpile@exprs.c.2021.snap

@@ -76,25 +76,25 @@ pub unsafe extern "C" fn inc_decl_with_rvalue_side_effect() {
 }
 #[no_mangle]
 pub unsafe extern "C" fn inc_decl_with_lvalue_side_effect() {
-    let ref mut c2rust_fresh2 = *lvalue_side_effect();
+    let c2rust_fresh2 = &raw mut *lvalue_side_effect();
     *c2rust_fresh2 += 1;
-    let ref mut c2rust_fresh3 = *lvalue_side_effect();
+    let c2rust_fresh3 = &raw mut *lvalue_side_effect();
     *c2rust_fresh3 -= 1;
-    let ref mut c2rust_fresh4 = *lvalue_side_effect();
+    let c2rust_fresh4 = &raw mut *lvalue_side_effect();
     *c2rust_fresh4 += 1;
-    let ref mut c2rust_fresh5 = *lvalue_side_effect();
+    let c2rust_fresh5 = &raw mut *lvalue_side_effect();
     *c2rust_fresh5 -= 1;
-    let ref mut c2rust_fresh6 = *lvalue_side_effect();
+    let c2rust_fresh6 = &raw mut *lvalue_side_effect();
     *c2rust_fresh6 += 1;
     let mut pre_inc: ::core::ffi::c_int = *c2rust_fresh6;
-    let ref mut c2rust_fresh7 = *lvalue_side_effect();
+    let c2rust_fresh7 = &raw mut *lvalue_side_effect();
     *c2rust_fresh7 -= 1;
     let mut pre_dec: ::core::ffi::c_int = *c2rust_fresh7;
-    let ref mut c2rust_fresh8 = *lvalue_side_effect();
+    let c2rust_fresh8 = &raw mut *lvalue_side_effect();
     let c2rust_fresh9 = *c2rust_fresh8;
     *c2rust_fresh8 = *c2rust_fresh8 + 1;
     let mut post_inc: ::core::ffi::c_int = c2rust_fresh9;
-    let ref mut c2rust_fresh10 = *lvalue_side_effect();
+    let c2rust_fresh10 = &raw mut *lvalue_side_effect();
     let c2rust_fresh11 = *c2rust_fresh10;
     *c2rust_fresh10 = *c2rust_fresh10 - 1;
     let mut post_dec: ::core::ffi::c_int = c2rust_fresh11;

c2rust-transpile/tests/snapshots/snapshots__transpile@exprs.c.2024.snap

@@ -76,25 +76,25 @@ pub unsafe extern "C" fn inc_decl_with_rvalue_side_effect() {
 }
 #[unsafe(no_mangle)]
 pub unsafe extern "C" fn inc_decl_with_lvalue_side_effect() {
-    let ref mut c2rust_fresh2 = *lvalue_side_effect();
+    let c2rust_fresh2 = &raw mut *lvalue_side_effect();
     *c2rust_fresh2 += 1;
-    let ref mut c2rust_fresh3 = *lvalue_side_effect();
+    let c2rust_fresh3 = &raw mut *lvalue_side_effect();
     *c2rust_fresh3 -= 1;
-    let ref mut c2rust_fresh4 = *lvalue_side_effect();
+    let c2rust_fresh4 = &raw mut *lvalue_side_effect();
     *c2rust_fresh4 += 1;
-    let ref mut c2rust_fresh5 = *lvalue_side_effect();
+    let c2rust_fresh5 = &raw mut *lvalue_side_effect();
     *c2rust_fresh5 -= 1;
-    let ref mut c2rust_fresh6 = *lvalue_side_effect();
+    let c2rust_fresh6 = &raw mut *lvalue_side_effect();
     *c2rust_fresh6 += 1;
     let mut pre_inc: ::core::ffi::c_int = *c2rust_fresh6;
-    let ref mut c2rust_fresh7 = *lvalue_side_effect();
+    let c2rust_fresh7 = &raw mut *lvalue_side_effect();
     *c2rust_fresh7 -= 1;
     let mut pre_dec: ::core::ffi::c_int = *c2rust_fresh7;
-    let ref mut c2rust_fresh8 = *lvalue_side_effect();
+    let c2rust_fresh8 = &raw mut *lvalue_side_effect();
     let c2rust_fresh9 = *c2rust_fresh8;
     *c2rust_fresh8 = *c2rust_fresh8 + 1;
     let mut post_inc: ::core::ffi::c_int = c2rust_fresh9;
-    let ref mut c2rust_fresh10 = *lvalue_side_effect();
+    let c2rust_fresh10 = &raw mut *lvalue_side_effect();
     let c2rust_fresh11 = *c2rust_fresh10;
     *c2rust_fresh10 = *c2rust_fresh10 - 1;
     let mut post_dec: ::core::ffi::c_int = c2rust_fresh11;