transpile: add tcfg: &TranspilerConfig to fn TypeConverter::new to simplify creation

There doesn't seem to be a point in calling `TypeConvert::new()` and then setting fields,
vs. just setting them in `fn new` to begin with.
We already don't want to `impl Default`.

Author: kkysen

c2rust-transpile/src/convert_type.rs

@@ -3,6 +3,7 @@ use crate::c_ast::*;
 use crate::diagnostics::TranslationResult;
 use crate::renamer::*;
 use crate::translator::variadic::mk_va_list_ty;
+use crate::TranspilerConfig;
 use crate::{CrateSet, ExternCrate};
 use c2rust_ast_builder::{mk, properties::*};
 use failure::format_err;
@@ -133,16 +134,9 @@ pub const RESERVED_NAMES: [&str; 100] = [
 ];
 
 impl TypeConverter {
-    // We don't provide a `Default` impl to simplify future compatibility:
-    // if `TypeConverter` ever gets fields incompatible with `Default`, then
-    // cleaning out the uses of `impl Default for TypeConverter` can be a pain.
-    // More practically, there is a single use of `TypeConverter::new` and no
-    // current plans to use a `Default` impl, so providing it isn't worth the
-    // potential breakage.
-    #[allow(clippy::new_without_default)]
-    pub fn new() -> TypeConverter {
+    pub fn new(tcfg: &TranspilerConfig) -> TypeConverter {
         TypeConverter {
-            translate_valist: false,
+            translate_valist: tcfg.translate_valist,
             renamer: Renamer::new(&RESERVED_NAMES),
             fields: HashMap::new(),
             suffix_names: HashMap::new(),

c2rust-transpile/src/translator/mod.rs

@@ -1533,9 +1533,7 @@ impl<'c> Translation<'c> {
         main_file: &Path,
     ) -> Self {
         let comment_context = CommentContext::new(&mut ast_context);
-        let mut type_converter = TypeConverter::new();
-
-        type_converter.translate_valist = tcfg.translate_valist;
+        let type_converter = TypeConverter::new(tcfg);
 
         let main_file = ast_context
             .find_file_id(main_file)