transpile: Use raw pointers for lvalues with side effects

Author: Rua

c2rust-transpile/src/translator/named_references.rs

@@ -124,11 +124,12 @@ impl<'c> Translation<'c> {
 
                 let ptr_name = self.renamer.borrow_mut().fresh();
 
-                // let ref mut p = lhs;
+                // let p = &raw mut lhs;
+                self.use_feature("raw_ref_op");
                 let compute_ref = mk().local_stmt(Box::new(mk().local(
-                    mk().mutbl().ident_ref_pat(&ptr_name),
+                    mk().ident_pat(&ptr_name),
                     None,
-                    Some(reference),
+                    Some(mk().mutbl().raw_borrow_expr(reference)),
                 )));
 
                 let write =

c2rust-transpile/tests/snapshots/snapshots__transpile@conditions.c.2021.snap

@@ -103,7 +103,7 @@ pub unsafe extern "C" fn conditional_operator(
     let mut y: *mut ::core::ffi::c_int = (buf as *mut ::core::ffi::c_int)
         .offset(1 as ::core::ffi::c_int as isize)
         as *mut ::core::ffi::c_int;
-    let ref mut c2rust_fresh0 = *if false { &raw mut y } else { &raw mut x };
+    let c2rust_fresh0 = &raw mut *if false { &raw mut y } else { &raw mut x };
     *c2rust_fresh0 = 10 as ::core::ffi::c_int as *mut ::core::ffi::c_int;
     *(buf as *mut ::core::ffi::c_int).offset(2 as ::core::ffi::c_int as isize) = if true {
         2 as ::core::ffi::c_int

c2rust-transpile/tests/snapshots/snapshots__transpile@conditions.c.2024.snap

@@ -103,7 +103,7 @@ pub unsafe extern "C" fn conditional_operator(
     let mut y: *mut ::core::ffi::c_int = (buf as *mut ::core::ffi::c_int)
         .offset(1 as ::core::ffi::c_int as isize)
         as *mut ::core::ffi::c_int;
-    let ref mut c2rust_fresh0 = *if false { &raw mut y } else { &raw mut x };
+    let c2rust_fresh0 = &raw mut *if false { &raw mut y } else { &raw mut x };
     *c2rust_fresh0 = 10 as ::core::ffi::c_int as *mut ::core::ffi::c_int;
     *(buf as *mut ::core::ffi::c_int).offset(2 as ::core::ffi::c_int as isize) = if true {
         2 as ::core::ffi::c_int