refactor: Support associated constants in reorganize_definitions#1746
Merged
Conversation
ahomescu
requested changes
Apr 21, 2026
Contributor
|
Thanks for figuring this out, the fix looks good generally (modulo a couple of minor comments). |
Rua
force-pushed
the
assoc-const-refactorer
branch
from
49fe72a to
b240976
Compare
ahomescu
reviewed
Apr 21, 2026
ahomescu
approved these changes
Apr 21, 2026
Rua
force-pushed
the
assoc-const-refactorer
branch
from
b240976 to
0839f7a
Compare
kkysen
reviewed
Apr 23, 2026
Rua
force-pushed
the
assoc-const-refactorer
branch
6 times, most recently
from
90c1410 to
d272ee6
Compare
Rua
force-pushed
the
assoc-const-refactorer
branch
2 times, most recently
from
f877b5f to
ccaba68
Compare
Rua
force-pushed
the
assoc-const-refactorer
branch
from
ccaba68 to
a7c55c3
Compare
kkysen
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was quite tricky to implement, but it's now working and #1659 passes its tests with these additions. Only
constassociated items are supported.typeitems could be added later, butfnis probably never going to work because they are too complex to test for equivalence.