refactor: Don't remove raw borrows in remove_unnecessary_refs#1811
Merged
Conversation
Rua
force-pushed
the
refactor-dont-remove-raw-borrows
branch
from
d5522de to
95ce56a
Compare
ahomescu
approved these changes
Jun 11, 2026
| fn remove_ref(expr: &mut P<Expr>) { | ||
| match &expr.kind { | ||
| ExprKind::AddrOf(_, _, inner) => *expr = inner.clone(), | ||
| ExprKind::AddrOf(BorrowKind::Ref, _, inner) => *expr = inner.clone(), |
Contributor
There was a problem hiding this comment.
This also covers &pin borrows, but I guess that's fine? The transpiler wouldn't emit those anyway.
ahomescu
added a commit
that referenced
this pull request
Jun 24, 2026
- Depends on #1811 - Fixes #1136 The strict provenance APIs changed since the currently used nightly 1.67, so I've selected the API based on the edition, and left comments for when things were changed. Casts involving function pointers are not covered by this, as they use transmutes, and it doesn't seem immediately obvious how to make that work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bugfix for a problem that showed itself in CI with #1810.