You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduces Seaport 1.6 with zone allowlisting and a new SIP-7 Immutable Signed Zone V3 (incl. authorizeOrder), with full tests and CI/dependency updates.
Contracts:
Add contracts/trading/seaport16/ImmutableSeaport.sol (Seaport 1.6 fork) with allowedZones, restricted-order enforcement, and zone validation across fulfill/match paths.
Add ImmutableSignedZoneV3 (SIP-7) with EIP-712 signing, authorizeOrder, validateOrder, access control, active signer management, and support for substandards 1, 3, 4, 6, 7, 8.
Add zone access control and SIP interfaces/errors.
Note for discussion: The authorizeOrder and validateOrder functions are assumed to be called together in that order which Seaport will guarantee. The functions are not view or pure (to support SIP-7 substandards 7 and 8 creator token standard callbacks), so they may change state. The functions are also currently not restricted to any particular caller - this was fine for previous versions of this zone which designated validateOrder as view function. Given the assumptions, the functions should be caller restricted to preserve the semantics of the creator token standard. What options do we have to apply restrictions?
Edit: Added caller (msg.sender) restriction to authorizeOrder and validateOrder functions. The Seaport address is obtained via the zone constructor for simplicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seaport 1.6 and Immutable Signed Zone V3
authorizeOrderfunction)Note
Introduces Seaport 1.6 with zone allowlisting and a new SIP-7 Immutable Signed Zone V3 (incl. authorizeOrder), with full tests and CI/dependency updates.
contracts/trading/seaport16/ImmutableSeaport.sol(Seaport 1.6 fork) withallowedZones, restricted-order enforcement, and zone validation across fulfill/match paths.contracts/trading/seaport16/conduit/ConduitController.sol.ImmutableSignedZoneV3(SIP-7) with EIP-712 signing,authorizeOrder,validateOrder, access control, active signer management, and support for substandards1, 3, 4, 6, 7, 8.SeaportValidator,ReadOnlyOrderValidator,SeaportValidatorHelper).test/trading/seaport16/**.@nomicfoundation/hardhat-foundry, compiler0.8.24(Cancún), per-file overrides for seaport16.seaport-16,seaport-core-16,seaport-types-16), Limit Breakcreator-token-standards; updateremappings.txt,.gitmodules,DEPS.md,foundry.lock, andpackage.json..gitignore: addcache_hardhatand Foundry outputs.Written by Cursor Bugbot for commit 0d669d0. This will update automatically on new commits. Configure here.