refactor(audience): address PR review — buildBase helper, consent payload fix

Review feedback from Natalie on PR #2830:

1. Extract buildBase() helper in Pixel class to deduplicate messageId,
   eventTimestamp, anonymousId, surface, and context fields across
   page(), identify(), fireSessionStart(), and fireSessionEnd().

2. Fix consent PUT payload: rename `consentLevel` to `status` and add
   `source` field to match backend OAS. Accept source as a parameter
   to createConsentManager() so pixel passes 'pixel' and web SDK can
   pass 'sdk'.

3. Add comment on direct fetch usage in consent (different method/payload
   than httpSend's BatchPayload POST).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: bkbooth

packages/audience/core/src/consent.test.ts

@@ -26,19 +26,19 @@ beforeEach(() => {
 describe('createConsentManager', () => {
   it('defaults to none when no initial level provided', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel');
     expect(manager.level).toBe('none');
   });
 
   it('uses the initial level when provided', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'anonymous');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel', 'anonymous');
     expect(manager.level).toBe('anonymous');
   });
 
   it('upgrades consent without modifying queue', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'none');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel', 'none');
 
     manager.setLevel('anonymous');
     expect(manager.level).toBe('anonymous');
@@ -48,7 +48,7 @@ describe('createConsentManager', () => {
 
   it('purges queue on downgrade to none', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'full');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel', 'full');
 
     manager.setLevel('none');
     expect(manager.level).toBe('none');
@@ -61,7 +61,7 @@ describe('createConsentManager', () => {
 
   it('strips userId on downgrade from full to anonymous', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'full');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel', 'full');
 
     manager.setLevel('anonymous');
     expect(manager.level).toBe('anonymous');
@@ -77,7 +77,7 @@ describe('createConsentManager', () => {
 
   it('fires PUT to consent endpoint on level change', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'none');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel', 'none');
 
     manager.setLevel('anonymous');
 
@@ -89,13 +89,14 @@ describe('createConsentManager', () => {
           'Content-Type': 'application/json',
           'x-immutable-publishable-key': 'pk_test',
         }),
+        body: JSON.stringify({ anonymousId: 'anon-1', status: 'anonymous', source: 'pixel' }),
       }),
     );
   });
 
   it('does nothing when setting the same level', () => {
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'anonymous');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel', 'anonymous');
 
     manager.setLevel('anonymous');
     expect(queue.purge).not.toHaveBeenCalled();
@@ -107,7 +108,7 @@ describe('createConsentManager', () => {
     Object.defineProperty(navigator, 'doNotTrack', { value: '1', configurable: true });
 
     const queue = createMockQueue();
-    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev');
+    const manager = createConsentManager(queue, 'pk_test', 'anon-1', 'dev', 'pixel');
     expect(manager.level).toBe('none');
 
     Object.defineProperty(navigator, 'doNotTrack', { value: '0', configurable: true });

packages/audience/core/src/consent.ts

@@ -30,6 +30,7 @@ export function createConsentManager(
   publishableKey: string,
   anonymousId: string,
   environment: Environment,
+  source: string,
   initialLevel?: ConsentLevel,
 ): ConsentManager {
   const dntDetected = detectDoNotTrack();
@@ -39,7 +40,10 @@ export function createConsentManager(
 
   function notifyBackend(level: ConsentLevel): void {
     const url = `${getBaseUrl(environment)}${CONSENT_PATH}`;
-    const payload = { anonymousId, consentLevel: level };
+    const payload = { anonymousId, status: level, source };
+    // Uses fetch directly rather than httpSend because this is a PUT
+    // to a different endpoint with a different payload shape than the
+    // message ingest POST that httpSend is designed for.
     fetch(url, {
       method: 'PUT',
       headers: {

packages/audience/pixel/src/pixel.test.ts

@@ -45,7 +45,7 @@ jest.mock('@imtbl/audience-core', () => ({
   }),
   getOrCreateSession: (...args: unknown[]) => mockGetOrCreateSession(...args),
   createConsentManager: jest.fn().mockImplementation(
-    (_queue: unknown, _key: unknown, _anonId: unknown, _env: unknown, level?: string) => {
+    (_queue: unknown, _key: unknown, _anonId: unknown, _env: unknown, _source: unknown, level?: string) => {
       let current = level ?? 'none';
       return {
         get level() { return current; },

packages/audience/pixel/src/pixel.ts

@@ -92,6 +92,7 @@ export class Pixel {
       key,
       this.anonymousId,
       environment,
+      'pixel',
       consentLevel,
     );
 
@@ -112,15 +113,10 @@ export class Pixel {
     const { sessionId, isNew } = getOrCreateSession(this.domain);
     this.refreshSession(sessionId, isNew);
     const attribution = collectAttribution();
-    const context = collectContext('@imtbl/pixel', PIXEL_VERSION);
 
     const message: PageMessage = {
+      ...this.buildBase(),
       type: 'page',
-      messageId: generateId(),
-      eventTimestamp: getTimestamp(),
-      anonymousId: this.anonymousId,
-      surface: 'pixel',
-      context,
       properties: {
         ...attribution,
         sessionId,
@@ -138,15 +134,10 @@ export class Pixel {
     this.userId = userId;
     const { sessionId, isNew } = getOrCreateSession(this.domain);
     this.refreshSession(sessionId, isNew);
-    const context = collectContext('@imtbl/pixel', PIXEL_VERSION);
 
     const message: IdentifyMessage = {
+      ...this.buildBase(),
       type: 'identify',
-      messageId: generateId(),
-      eventTimestamp: getTimestamp(),
-      anonymousId: this.anonymousId,
-      surface: 'pixel',
-      context,
       userId,
       traits: {
         ...traits,
@@ -186,13 +177,9 @@ export class Pixel {
     if (!this.canTrack()) return;
 
     const message: TrackMessage = {
+      ...this.buildBase(),
       type: 'track',
       eventName: 'session_start',
-      messageId: generateId(),
-      eventTimestamp: getTimestamp(),
-      anonymousId: this.anonymousId,
-      surface: 'pixel',
-      context: collectContext('@imtbl/pixel', PIXEL_VERSION),
       properties: { sessionId },
       userId: this.consent!.level === 'full' ? this.userId : undefined,
     };
@@ -208,13 +195,9 @@ export class Pixel {
       : undefined;
 
     const message: TrackMessage = {
+      ...this.buildBase(),
       type: 'track',
       eventName: 'session_end',
-      messageId: generateId(),
-      eventTimestamp: getTimestamp(),
-      anonymousId: this.anonymousId,
-      surface: 'pixel',
-      context: collectContext('@imtbl/pixel', PIXEL_VERSION),
       properties: {
         sessionId: this.sessionId,
         duration,
@@ -247,6 +230,19 @@ export class Pixel {
     }
   }
 
+  // -- Helpers ------------------------------------------------------------
+
+  // eslint-disable-next-line class-methods-use-this
+  private buildBase() {
+    return {
+      messageId: generateId(),
+      eventTimestamp: getTimestamp(),
+      anonymousId: this.anonymousId,
+      surface: 'pixel' as const,
+      context: collectContext('@imtbl/pixel', PIXEL_VERSION),
+    };
+  }
+
   // -- Guards -------------------------------------------------------------
 
   private canTrack(): boolean {