Skip to content

Commit a514986

Browse files
authored
chore(passport): Fix Seaport fulfillAvailableAdvancedOrders in Passport SDK sample app (#2728)
1 parent 3fec0e8 commit a514986

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

packages/passport/sdk-sample-app/src/components/imx/Trade.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React, { useEffect, useState } from 'react';
1+
import React, { useCallback, useEffect, useState } from 'react';
22
import {
33
Alert, Button, Form, Image, Offcanvas, Spinner, Stack, Table,
44
} from 'react-bootstrap';
@@ -25,7 +25,7 @@ function Trade({ showModal: showTradeModal, setShowModal: setShowTradeModal }: M
2525
const { sdkClient } = useImmutableProvider();
2626
const { imxProvider } = usePassportProvider();
2727

28-
const getOrders = async (e?: React.FormEvent<HTMLFormElement>) => {
28+
const getOrders = useCallback(async (e?: React.FormEvent<HTMLFormElement>) => {
2929
e?.preventDefault();
3030
e?.stopPropagation();
3131

@@ -45,11 +45,11 @@ function Trade({ showModal: showTradeModal, setShowModal: setShowTradeModal }: M
4545
setOrders(result.result);
4646
setLoadingOrders(false);
4747
}
48-
};
48+
}, [sdkClient, showTradeModal, sellTokenName]);
4949

5050
useEffect(() => {
5151
getOrders().catch(console.error);
52-
}, [showTradeModal, sdkClient, getOrders]);
52+
}, [getOrders]);
5353

5454
const handleCloseTrade = () => {
5555
setLoadingTrade(false);

packages/passport/sdk-sample-app/src/components/zkevm/Request.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,11 @@ function Request({ showModal, setShowModal }: ModalProps) {
187187
if (request.params) {
188188
const newParams = params;
189189
request.params.forEach((param, i) => {
190-
newParams[i] = JSON.stringify(param);
190+
try {
191+
newParams[i] = JSON.stringify(param);
192+
} catch (err) {
193+
newParams[i] = param;
194+
}
191195
});
192196
setParams(newParams);
193197
}

0 commit comments

Comments
 (0)