cache register user promise

Author: CodeSchwert

packages/passport/sdk/src/zkEvm/zkEvmProvider.ts

@@ -77,6 +77,12 @@ export class ZkEvmProvider implements Provider {
 
   #signerInitialisationError: unknown | undefined;
 
+  /**
+   * Cache for the user registration promise to prevent race conditions
+   * when multiple eth_requestAccounts calls happen concurrently
+   */
+  #userRegistrationPromise?: Promise<string> | undefined;
+
   public readonly isPassport: boolean = true;
 
   constructor({
@@ -133,9 +139,17 @@ export class ZkEvmProvider implements Provider {
 
   #handleLogout = () => {
     this.#ethSigner = undefined;
+    this.#userRegistrationPromise = undefined;
     this.#providerEventEmitter.emit(ProviderEvent.ACCOUNTS_CHANGED, []);
   };
 
+  /**
+   * Clear the cached user registration promise
+   */
+  #clearUserRegistrationCache = () => {
+    this.#userRegistrationPromise = undefined;
+  };
+
   /**
    * This method is called by `eth_requestAccounts` and asynchronously initialises the signer.
    * The signer is stored in a promise so that it can be retrieved by the provider
@@ -247,18 +261,32 @@ export class ZkEvmProvider implements Provider {
           if (!isZkEvmUser(user)) {
             flow.addEvent('startUserRegistration');
 
-            const ethSigner = await this.#getSigner();
-            flow.addEvent('ethSignerResolved');
+            // Check if registration is already in progress to prevent race conditions
+            if (!this.#userRegistrationPromise) {
+              const ethSigner = await this.#getSigner();
+              flow.addEvent('ethSignerResolved');
+
+              // Cache the registration promise to prevent concurrent registrations
+              this.#userRegistrationPromise = registerZkEvmUser({
+                ethSigner,
+                authManager: this.#authManager,
+                multiRollupApiClients: this.#multiRollupApiClients,
+                accessToken: user.accessToken,
+                rpcProvider: this.#rpcProvider,
+                flow,
+              });
+            }
 
-            userZkEvmEthAddress = await registerZkEvmUser({
-              ethSigner,
-              authManager: this.#authManager,
-              multiRollupApiClients: this.#multiRollupApiClients,
-              accessToken: user.accessToken,
-              rpcProvider: this.#rpcProvider,
-              flow,
-            });
-            flow.addEvent('endUserRegistration');
+            try {
+              userZkEvmEthAddress = await this.#userRegistrationPromise;
+              flow.addEvent('endUserRegistration');
+              // Clear the cache after successful registration so future calls get fresh user data
+              this.#clearUserRegistrationCache();
+            } catch (error) {
+              // Clear the cached promise on error so it can be retried
+              this.#clearUserRegistrationCache();
+              throw error;
+            }
           } else {
             userZkEvmEthAddress = user.zkEvm.ethAddress;
           }