Skip to content

Commit d1b3c07

Browse files
authored
fix(passport): ID-3874 Fix logout issue (#2671)
1 parent 0139d12 commit d1b3c07

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

packages/passport/sdk/src/authManager.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,8 +455,7 @@ describe('AuthManager', () => {
455455
PassportErrorType.LOGOUT_ERROR,
456456
),
457457
);
458-
// In silent mode, signoutSilent is called in parallel with revokeTokens
459-
expect(mockSignoutSilent).toHaveBeenCalled();
458+
expect(mockSignoutSilent).not.toHaveBeenCalled();
460459
});
461460
});
462461

packages/passport/sdk/src/authManager.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -350,13 +350,11 @@ export default class AuthManager {
350350

351351
public async logout(): Promise<void> {
352352
return withPassportError<void>(async () => {
353+
await this.userManager.revokeTokens(['refresh_token']);
354+
353355
if (this.logoutMode === 'silent') {
354-
await Promise.all([
355-
this.userManager.revokeTokens(['refresh_token']),
356-
this.userManager.signoutSilent(),
357-
]);
356+
await this.userManager.signoutSilent();
358357
} else {
359-
await this.userManager.revokeTokens(['refresh_token']);
360358
await this.userManager.signoutRedirect();
361359
}
362360
}, PassportErrorType.LOGOUT_ERROR);

0 commit comments

Comments
 (0)