fix(StarkEx): Revert StarkEx Ethers v6#2610
Closed
zaidarain1 wants to merge 19 commits into
Closed
Conversation
|
View your CI Pipeline Execution ↗ for commit 2427970.
☁️ Nx Cloud last updated this comment at |
Replaces string-based signature message with raw bytes in stark key generation to prevent encoding issues in non-English systems. This aligns with the fix for wallet connection message encoding.
- Add debug logs to track utf-8 byte encoding/decoding - Compare utf-8 bytes between TextEncoder/TextDecoder and ethers.toUtf8Bytes - Attempt to fix encoding issue by using ethers.toUtf8Bytes directly for signing - Add validation that encoded bytes match expected connection string
zaidarain1
force-pushed
the
fix/revert-starkex-ethersv6
branch
from
06ff334 to
b9a0493
Compare
keithbro-imx
reviewed
Apr 4, 2025
| Buffer: true, | ||
| process: true, | ||
| }, | ||
| modules: ['crypto', 'buffer', 'process'] |
Contributor
Author
There was a problem hiding this comment.
It let's the polyfill plugin handle the polyfills, for some reason crypto isn't getting polyfilled for a specific package even if it is being specified here, removing this line fixes that issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.