Skip to content

FEAT: DVR-328 | passport event handling feature#2617

Merged
darrenmelvison1 merged 10 commits into
mainfrom
DVR-328-passport-event-handling
Apr 9, 2025
Merged

FEAT: DVR-328 | passport event handling feature#2617
darrenmelvison1 merged 10 commits into
mainfrom
DVR-328-passport-event-handling

Conversation

@darrenmelvison1
Copy link
Copy Markdown
Contributor

Description

Added passport event handling feature page to an existing login-with-nextjs app

JIRA: https://immutable.atlassian.net/browse/DVR-328

@darrenmelvison1 darrenmelvison1 requested a review from a team April 8, 2025 05:05
@darrenmelvison1 darrenmelvison1 requested a review from a team as a code owner April 8, 2025 05:05
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 8, 2025

View your CI Pipeline Execution ↗ for commit b7ae8bd.

Command Status Duration Result
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1s View ↗
nx affected -t build,lint,test ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-09 05:12:58 UTC

Copy link
Copy Markdown
Contributor

@proletesseract proletesseract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to;

  • add basic e2e tests
  • once my other feedback is integrated, please generate the updated tutorial files.

Comment thread examples/passport/login-with-nextjs/src/app/auth-event-handling/page.tsx Outdated
Comment thread examples/passport/login-with-nextjs/src/app/auth-event-handling/page.tsx Outdated
Comment thread examples/passport/login-with-nextjs/src/app/auth-event-handling/page.tsx Outdated
Comment thread examples/passport/login-with-nextjs/src/app/auth-event-handling/page.tsx Outdated
Comment thread examples/passport/login-with-nextjs/src/app/auth-event-handling/page.tsx Outdated
Comment thread pnpm-lock.yaml
Copy link
Copy Markdown
Contributor

@proletesseract proletesseract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenmelvison1 darrenmelvison1 added this pull request to the merge queue Apr 9, 2025
Merged via the queue into main with commit 137e284 Apr 9, 2025
7 checks passed
@darrenmelvison1 darrenmelvison1 deleted the DVR-328-passport-event-handling branch April 9, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants