Skip to content

fix(checkout): Fetch crypto to USD conversion via our own subgraph#2620

Merged
jeetparikh merged 7 commits into
mainfrom
feat/GFI-319-new-cryptofiat-class
Apr 15, 2025
Merged

fix(checkout): Fetch crypto to USD conversion via our own subgraph#2620
jeetparikh merged 7 commits into
mainfrom
feat/GFI-319-new-cryptofiat-class

Conversation

@jeetparikh
Copy link
Copy Markdown
Contributor

We use our own subgraph to get accurate USD pricing for crypto on zkEVM as compared to coingecko API that favours L1 pools.

This PR only changes the Swap Widget to use this new API

@jeetparikh jeetparikh changed the title fix(checkout) Fetch crypto to USD conversion via our own subgraph fix(checkout): Fetch crypto to USD conversion via our own subgraph Apr 14, 2025
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 14, 2025

View your CI Pipeline Execution ↗ for commit d772961.

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 2m 3s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 1m View ↗

☁️ Nx Cloud last updated this comment at 2025-04-15 04:33:33 UTC

@jeetparikh jeetparikh marked this pull request as ready for review April 15, 2025 03:56
@jeetparikh jeetparikh requested a review from a team as a code owner April 15, 2025 03:56
keithbro-imx
keithbro-imx previously approved these changes Apr 15, 2025
setConversions(data);
setError(null);
} catch (err) {
setError(err instanceof Error ? err : new Error('Failed to fetch conversions'));
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setError(err instanceof Error ? err : new Error('Failed to fetch conversions'));
setError(err instanceof Error ? err : new Error('Failed to fetch conversions: '+err));

@jeetparikh jeetparikh added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025
@jeetparikh jeetparikh added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025
@jeetparikh jeetparikh added this pull request to the merge queue Apr 15, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 15, 2025
@jeetparikh jeetparikh added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 5fd5b7c Apr 15, 2025
7 checks passed
@jeetparikh jeetparikh deleted the feat/GFI-319-new-cryptofiat-class branch April 15, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants