feat(passport): Add extra params support when init passport in the game bridge#2626
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 092e785.
☁️ Nx Cloud last updated this comment at |
ImmutableJeffrey
approved these changes
May 12, 2025
naveen-imtb
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add extra params support when init passport in the game bridge. This is in preparation of custom login UI inside GameSDKs.
Detail and impact of the change
Added
Game Bridge now supports the
extraParamswhen initialising passport client. BecauseextraParamsneeds to be changed every user clicks on a different login option, an additional change is introduced to re-initialise passport client when configuration changes.