Skip to content

fix(passport): no window opener#2629

Closed
nattb8 wants to merge 12 commits into
mainfrom
fix/no-window-opener
Closed

fix(passport): no window opener#2629
nattb8 wants to merge 12 commits into
mainfrom
fix/no-window-opener

Conversation

@nattb8
Copy link
Copy Markdown
Contributor

@nattb8 nattb8 commented May 23, 2025

Hi👋, please ensure the PR title follows the below standards:

  • PR is titled with conventional commit style naming: type(scope): message. For example: feat(passport): my new feature
  • If you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities, add a ! after the type(scope), for example feat(passport)!: my new breaking feature

Context

ID-3722

Facebook login in Play is currently broken - users get stuck on the "Welcome, you're logged in" page and aren't redirected back to the app. This doesn't affect Google, Apple, or email login. The issue has been reproduced in the Passport sample app and is caused by a No window.opener. Can't complete notification. error during the callback.

A fix has been merged into the main branch of oidc-client-ts, but it hasn't been included in an official release. Since their release schedule is irregular, we’re applying a temporary workaround to unblock affected teams.

Detail and impact of the change

Changed

Temporarily updated our TS SDK to depend on the main branch of oidc-client-ts to include the fix.

Anything else worth calling out?

This will be published as an alpha release to unblock teams affected by the Facebook login issue.
Once oidc-client-ts publishes an official release with the fix, we'll update our dependency accordingly and release a stable SDK version.

@nattb8 nattb8 requested a review from a team as a code owner May 23, 2025 00:33
@nattb8 nattb8 changed the title [ID-3722] fix(passport): no window opener [DO NOT MERGE][ID-3722] fix(passport): no window opener May 23, 2025
@nattb8 nattb8 marked this pull request as draft May 23, 2025 00:44
@nattb8 nattb8 changed the title [DO NOT MERGE][ID-3722] fix(passport): no window opener fix(passport): no window opener May 23, 2025
@nattb8 nattb8 force-pushed the fix/no-window-opener branch 2 times, most recently from 34c216a to 3ce7f22 Compare May 23, 2025 02:03
@nattb8 nattb8 force-pushed the fix/no-window-opener branch from 3ce7f22 to 1c069e4 Compare May 23, 2025 02:10
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 23, 2025

View your CI Pipeline Execution ↗ for commit a631f67.

Command Status Duration Result
nx affected -t build,lint,test ❌ Failed 47s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ❌ Failed 5s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-26 01:13:06 UTC

@nattb8 nattb8 closed this May 26, 2025
@nattb8 nattb8 deleted the fix/no-window-opener branch May 27, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant