chore: refactor direct login to use object#2677
Closed
ImmutableJeffrey wants to merge 2 commits into
Closed
Conversation
|
View your CI Pipeline Execution ↗ for commit 6d98e14
☁️ Nx Cloud last updated this comment at |
| * Note: This takes precedence over useCachedSession if both are true | ||
| * @param {boolean} [options.useRedirectFlow] - If true, uses redirect flow instead of popup flow | ||
| * @param {DirectLoginMethod} [options.directLoginMethod] - If provided, directly redirects to the specified login method | ||
| * @param {DirectLoginOptions} [options.directLoginOptions] - Type-safe login options. For email login, use { method: 'email', email: 'user@example.com' }. For social login, use { method: 'google' } etc. |
Contributor
There was a problem hiding this comment.
I wouldn't comment on the options being type-safe, it makes the comment seem like it was written by an LLM 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureSummary
Refactor direct login method from direct login method to direct login options
Jira: ID-3896
Detail and impact of the change
Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?