fix(wallet): Ensure transaction simulation throws an error for non-native clients on transaction simulation revert#2806
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 5c1c4f7
☁️ Nx Cloud last updated this comment at |
naveen-imtb
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureSummary
Fall through to throwing an error when the guardian responds with a
422for transaction evaluation for non-native clients.Detail and impact of the change
The sdk checks the response code when simulating transactions.
When the response code is a
422andcrossSdkBridgeEnabledis true (native clients), the sdk will throw an error. However, there is a bug in this flow, where ifcrossSdkBridgeEnabledis false, the sdk would instead return an invalid{ confirmationRequired: true }response.This particular path is dead-code, as the guardian service only returns
422for native clients. However, it is still preferable to remove it and improve the clarity of the flow.Added
Changed
Deprecated
Removed
Fixed
Security
Anything else worth calling out?