Skip to content

chore(passport)!: BSB-6: remove x-client and x-provider StarkEx packages#2809

Merged
rodrigo-fournier-immutable merged 4 commits into
mainfrom
remove/BSB-6-sdk-starkex-x-client-x-provider
Apr 7, 2026
Merged

chore(passport)!: BSB-6: remove x-client and x-provider StarkEx packages#2809
rodrigo-fournier-immutable merged 4 commits into
mainfrom
remove/BSB-6-sdk-starkex-x-client-x-provider

Conversation

@naveen-imtb

Copy link
Copy Markdown
Contributor
  • PR is titled with conventional commit style naming
  • Breaking change indicated with !

Summary

Remove @imtbl/x-client and @imtbl/x-provider packages — deprecated StarkEx/IMX modules with no active consumers.

Detail and impact of the change

Removed

  • packages/x-client/ (90 files) — StarkEx client SDK (IMXClient, stark key generation, signable token utils)
  • packages/x-provider/ (109 files) — StarkEx provider (IMX wallet, signable actions, L1 providers, sample app)
  • @imtbl/sdk/x public entrypoint — consumers importing from @imtbl/sdk/x will break
  • packages/internal/toolkit/src/convertToSignableToken.ts — only consumer was x-client
  • tests/func-tests/imx/ (43 files) — StarkEx functional tests
  • examples/_deprecated/free-mint-with-minting-backend/ (72 files) — deprecated minting example
  • @imtbl/sdk/x_client moduleNameMapper from zkevm jest config
  • x-client, x-provider, x-provider/src/sample-app entries from pnpm-workspace.yaml

Anything else worth calling out?

  • This is stacked on top of #2808 (Passport StarkEx removal) — review only the delta in this PR
  • All internal consumers (passport, game-bridge) already had their x-client/x-provider deps removed in refactor(passport)!: BSB-6: remove StarkEx support from Passport SDK #2808
  • Eliminates CI flakiness from x-client tests that make live HTTP calls to api.x.immutable.com
  • 291 files changed, -32,951 lines (almost entirely deletions)
  • The combined branch will be used to publish a premajor pre-release for customer testing

@naveen-imtb naveen-imtb requested a review from a team as a code owner March 30, 2026 03:17
@nx-cloud

nx-cloud Bot commented Mar 30, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c35d583

Command Status Duration Result
nx affected -t build,lint,test ✅ Succeeded 8s View ↗
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-07 06:42:43 UTC

JCSanPedro
JCSanPedro previously approved these changes Mar 30, 2026
@naveen-imtb naveen-imtb changed the title chore(passport)!: remove x-client and x-provider StarkEx packages chore(passport)!: BSB-6: remove x-client and x-provider StarkEx packages Mar 31, 2026
@JCSanPedro JCSanPedro changed the base branch from remove/BSB-6-sdk-starkex-guardian-client to main April 7, 2026 05:36
@JCSanPedro JCSanPedro dismissed their stale review April 7, 2026 05:36

The base branch was changed.

@JCSanPedro JCSanPedro requested a review from a team as a code owner April 7, 2026 05:36
…x entrypoint

Delete the entire x-client and x-provider StarkEx packages, remove the
@imtbl/sdk/x public entrypoint, clean up toolkit's convertToSignableToken
helper (only consumed by x-client/x-provider), delete IMX functional tests,
remove deprecated IMX example app, and update workspace config.
Revert removal of x-client and x-provider packages and the @imtbl/sdk/x
entrypoint. These will be removed in a dedicated follow-up PR to keep
the Passport StarkEx cleanup scoped to passport-specific changes.
These tests hit api.x.immutable.com with no mocking, causing failures
when Nx cache misses. StarkEx/IMX is deprecated and these tests will
be removed when x-client is deleted in a follow-up PR.
Delete packages/x-client/ and packages/x-provider/ entirely — these
are StarkEx/IMX-specific and deprecated. Also removes:
- @imtbl/sdk/x public entrypoint
- toolkit's convertToSignableToken (only consumer was x-client)
- tests/func-tests/imx/ (StarkEx functional tests)
- examples/_deprecated/free-mint-with-minting-backend/
- x_client moduleNameMapper from zkevm jest config

BREAKING CHANGE: @imtbl/sdk/x entrypoint is removed. Consumers
importing from @imtbl/sdk/x must migrate to zkEVM equivalents.
@rodrigo-fournier-immutable rodrigo-fournier-immutable force-pushed the remove/BSB-6-sdk-starkex-x-client-x-provider branch from 301b606 to c35d583 Compare April 7, 2026 06:24
@rodrigo-fournier-immutable rodrigo-fournier-immutable added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 352f909 Apr 7, 2026
7 checks passed
@rodrigo-fournier-immutable rodrigo-fournier-immutable deleted the remove/BSB-6-sdk-starkex-x-client-x-provider branch April 7, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants