refactor(audience): remove redundant Required/Optional JSDoc (SDK-116)#2852
Merged
ImmutableJeffrey merged 1 commit intoApr 14, 2026
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 5c59dce
☁️ Nx Cloud last updated this comment at |
TypeScript's `?` modifier already encodes property optionality at the type level. The JSDoc labels duplicate what the syntax says without adding information. Follow-up to #2850. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ImmutableJeffrey
force-pushed
the
refactor/audience-remove-required-optional-jsdoc
branch
from
9546c7d to
5c59dce
Compare
nattb8
approved these changes
Apr 14, 2026
ImmutableJeffrey
deleted the
refactor/audience-remove-required-optional-jsdoc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
/** Required. *///** Optional. */JSDoc labels from every property inevents.ts. TypeScript's?modifier already encodes optionality — the labels duplicate the syntax without adding information.Linear: SDK-116.